Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce allocations in SelectorMap (Rule Hash) code #1299

Merged
merged 5 commits into from Nov 22, 2013
Merged

Reduce allocations in SelectorMap (Rule Hash) code #1299

merged 5 commits into from Nov 22, 2013
+59 −39

Commits on Nov 22, 2013

  1. Insert rules in SelectorMap manually to avoid unnecessary allocation.

    @pradeep90
    pradeep90 committed Nov 22, 2013
    7d90cc0

  2. Eliminate use of `map` by using a for loop.

    @pradeep90
    pradeep90 committed Nov 22, 2013
    92f4a43

  3. Avoid unnecessary cloning of Rule in SelectorMap code. 

    Do this by receiving a borrowed pointer in get_id_name(), etc..
Also, move the received argument in insert() method (instead of cloning it).
    @pradeep90
    pradeep90 committed Nov 22, 2013
    1d1a259

  4. Make Rule have Arc<Selector> to eliminate allocation while cloning.

    @pradeep90
    pradeep90 committed Nov 22, 2013
    cae74b4

  5. Use push instead of referring to the last element.

    @pradeep90
    pradeep90 committed Nov 22, 2013
    Loading status checks…
    5
    ae1f168
You can’t perform that action at this time.