New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce allocations in SelectorMap (Rule Hash) code #1299
Merged
+59
−39
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7d90cc0
Insert rules in SelectorMap manually to avoid unnecessary allocation.
pradeep90 92f4a43
Eliminate use of `map` by using a for loop.
pradeep90 1d1a259
Avoid unnecessary cloning of Rule in SelectorMap code.
pradeep90 cae74b4
Make Rule have Arc<Selector> to eliminate allocation while cloning.
pradeep90 ae1f168
Use push instead of referring to the last element.
pradeep90 File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.
Eliminate use of `map` by using a for loop.
- Loading branch information
commit 92f4a430ea163af3d4ab969b8a1d919ccb287d79
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nit: I doubt it makes a difference, but this will be slightly faster and clearer (avoids the bounds check) if you just do:
The push does a move of
curr_declarationsso it won't copy.