Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix step 10 of eventdispatcher::dispatch_event (fixes #11609) #13014

Merged
merged 1 commit into from Aug 24, 2016

Conversation

@nox
Copy link
Member

nox commented Aug 24, 2016

This change is Reviewable

@highfive
Copy link

highfive commented Aug 24, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/eventdispatcher.rs, components/script/dom/event.rs
@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 24, 2016

Add spec links to the new methods on Event and r=me

We consolidate steps 10-12 in a single function to expose less general-purpose
mutating methods on Event.
@nox nox force-pushed the nox:dispatch branch from 4b4ebcc to 540fe15 Aug 24, 2016
@nox
Copy link
Member Author

nox commented Aug 24, 2016

@bors-servo r=Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented Aug 24, 2016

📌 Commit 540fe15 has been approved by Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented Aug 24, 2016

Testing commit 540fe15 with merge ccf79de...

bors-servo added a commit that referenced this pull request Aug 24, 2016
Fix step 10 of eventdispatcher::dispatch_event (fixes #11609)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13014)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 24, 2016

@bors-servo bors-servo merged commit 540fe15 into servo:master Aug 24, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.