Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCheck for license only in Cargo.toml #13027
Merged
Conversation
highfive
commented
Aug 24, 2016
|
Heads up! This PR modifies the following files:
|
| @@ -117,7 +117,7 @@ def test_webidl(self): | |||
| self.assertNoMoreErrors(errors) | |||
|
|
|||
| def test_toml(self): | |||
| errors = tidy.collect_errors_for_files(iterFile('test.toml'), [tidy.check_toml], [], print_text=False) | |||
| errors = tidy.collect_errors_for_files(iterFile('test-Cargo.toml'), [tidy.check_toml], [], print_text=False) | |||
This comment has been minimized.
This comment has been minimized.
wafflespeanut
Aug 25, 2016
•
Member
Nit: Let the new name be lower-cased (like, test-cargo.toml)
Why should this be prefixed this with test-? Why can't this simply be Cargo.toml?
This comment has been minimized.
This comment has been minimized.
| @@ -312,7 +311,7 @@ def find_reverse_dependencies(dependency, version, content): | |||
|
|
|||
|
|
|||
| def check_toml(file_name, lines): | |||
| if not file_name.endswith(".toml"): | |||
| if not file_name.endswith("Cargo.toml"): | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
UK992
Aug 25, 2016
Author
Contributor
This won't work, because file_name is a path, not only file name.
This comment has been minimized.
This comment has been minimized.
|
Thanks for the cleanup! :) @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 25, 2016
Check for license only in Cargo.toml This fix problem with false reporting about missing license in every toml file, that is not Cargo.toml r? @wafflespeanut <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13027) <!-- Reviewable:end -->
|
|
|
@bors-servo retry #13037 |
bors-servo
added a commit
that referenced
this pull request
Aug 25, 2016
Check for license only in Cargo.toml This fix problem with false reporting about missing license in every toml file, that is not Cargo.toml r? @wafflespeanut <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13027) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
UK992 commentedAug 24, 2016
•
edited by larsbergstrom
This fix problem with false reporting about missing license in every toml file, that is not Cargo.toml
r? @wafflespeanut
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is