Implement transition event and infrastructure #13056

KiChjang · 2016-08-26T15:55:39Z

Fixes #10245.

This change is

highfive · 2016-08-26T15:55:42Z

Heads up! This PR modifies the following files:

@bholley: components/style/data.rs, components/style/traversal.rs, components/style/matching.rs, components/style/Cargo.toml, components/style/lib.rs, components/style/dom.rs, components/style/animation.rs, components/style/context.rs, components/style/parallel.rs
@KiChjang: components/script/dom/webidls/EventHandler.webidl, components/script/dom/webidls/TransitionEvent.webidl, components/script/dom/mod.rs, components/script_traits/lib.rs, components/script_traits/lib.rs, components/script/lib.rs, components/script/dom/macros.rs, components/script/Cargo.toml, components/script/script_thread.rs, components/script/layout_wrapper.rs, components/script/dom/transitionevent.rs

highfive · 2016-08-26T15:55:43Z

Warning

These commits modify unsafe code. Please review it carefully!
These commits modify style, layout, and script code, but no tests are modified. Please consider adding a test!

KiChjang · 2016-08-26T15:55:49Z

@bors-servo try

bors-servo · 2016-08-26T15:55:51Z

⌛ Trying commit 80ead58 with merge e2becc6...


        Auto merge of #13056 - KiChjang:transition-event, r=<try>

Implement transition event and infrastructure Fixes #10245.

bors-servo · 2016-08-26T16:05:21Z

💔 Test failed - linux-dev

KiChjang · 2016-08-26T16:41:16Z

@bors-servo try

bors-servo · 2016-08-26T16:51:20Z

⌛ Trying commit 5adb03c with merge 6e54ed7...


        Auto merge of #13056 - KiChjang:transition-event, r=<try>

Implement transition event and infrastructure Fixes #10245.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056)

jdm · 2016-08-26T17:10:46Z

r? @nox
I'm going to be away all next week and won't be able to review this promptly.

bors-servo · 2016-08-26T17:46:21Z

💔 Test failed - linux-dev

jdm · 2016-08-26T18:34:05Z

We should modify the test mentioned in #10473 (comment) and reenable it.

KiChjang · 2016-08-26T21:42:47Z

@bors-servo try

bors-servo · 2016-08-26T21:42:49Z

⌛ Trying commit aa66059 with merge 1168383...


        Auto merge of #13056 - KiChjang:transition-event, r=<try>

Implement transition event and infrastructure Fixes #10245.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056)

bors-servo · 2016-08-26T21:54:12Z

💔 Test failed - linux-dev

KiChjang · 2016-08-26T22:02:07Z

@bors-servo try


        Emit TransitionEnd events in the layout thread and process it in the …

…script thread

KiChjang · 2016-10-12T02:36:26Z

'kay, let's try this again. @bors-servo r=mbrubeck

bors-servo · 2016-10-12T02:36:26Z

📌 Commit 668163e has been approved by mbrubeck

bors-servo · 2016-10-12T02:36:29Z

⌛ Testing commit 668163e with merge 16570b7...


        Auto merge of #13056 - KiChjang:transition-event, r=mbrubeck

Implement transition event and infrastructure Fixes #10245.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056)

bors-servo · 2016-10-12T03:51:32Z

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

bors-servo · 2016-10-12T03:51:33Z

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

Manishearth · 2016-10-12T04:23:21Z

@bors-servo retry

github bork

bors-servo · 2016-10-12T04:25:24Z

⌛ Testing commit 668163e with merge 5a14d09...


        Auto merge of #13056 - KiChjang:transition-event, r=mbrubeck

Implement transition event and infrastructure Fixes #10245.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056)

bors-servo · 2016-10-12T05:14:34Z

💔 Test failed - mac-rel-wpt2

Manishearth · 2016-10-12T06:49:26Z

@bors-servo retry

#13662

bors-servo · 2016-10-12T07:08:37Z

⌛ Testing commit 668163e with merge cd2f950...


        Auto merge of #13056 - KiChjang:transition-event, r=mbrubeck

Implement transition event and infrastructure Fixes #10245.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13056)

bors-servo · 2016-10-12T08:33:46Z

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

highfive assigned jdm Aug 26, 2016

highfive added the S-awaiting-review label Aug 26, 2016

bors-servo added a commit that referenced this pull request Aug 26, 2016

Auto merge of #13056 - KiChjang:transition-event, r=<try>

Loading status checks…

e2becc6

Implement transition event and infrastructure Fixes #10245.

highfive added the S-tests-failed label Aug 26, 2016

KiChjang mentioned this pull request Aug 26, 2016

Support 'letter spacing' property in gecko-lib #12823

Closed

highfive removed the S-tests-failed label Aug 26, 2016

highfive assigned nox and unassigned jdm Aug 26, 2016

highfive added the S-tests-failed label Aug 26, 2016

KiChjang force-pushed the KiChjang:transition-event branch from 5adb03c to aa66059 Aug 26, 2016

highfive removed the S-tests-failed label Aug 26, 2016

highfive added the S-tests-failed label Aug 26, 2016

KiChjang force-pushed the KiChjang:transition-event branch from aa66059 to b4d6459 Aug 26, 2016

highfive removed the S-tests-failed label Aug 26, 2016

KiChjang force-pushed the KiChjang:transition-event branch from 0270858 to 668163e Oct 12, 2016

highfive added S-awaiting-review and removed S-tests-failed labels Oct 12, 2016

Emit TransitionEnd events in the layout thread and process it in the …

Loading status checks…

668163e

…script thread

highfive added S-awaiting-merge and removed S-awaiting-review labels Oct 12, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Oct 12, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Oct 12, 2016

bors-servo merged commit 668163e into servo:master Oct 12, 2016
1 of 3 checks passed

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details

continuous-integration/travis-ci/pr The Travis CI build failed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Oct 12, 2016

KiChjang deleted the KiChjang:transition-event branch Oct 12, 2016

This was referenced Oct 12, 2016

Use atoms for transition events #13725

Open

Support pseudo elements for transition events #13726

Closed

emilio mentioned this pull request Nov 2, 2016

script: Try to conform a bit more to "The event loop processing model" #13864

Closed

3 of 3 tasks complete

servo / servo

Implement transition event and infrastructure #13056

Implement transition event and infrastructure #13056

KiChjang commented Aug 26, 2016 •

edited by larsbergstrom

highfive commented Aug 26, 2016

highfive commented Aug 26, 2016

KiChjang commented Aug 26, 2016

bors-servo commented Aug 26, 2016

bors-servo commented Aug 26, 2016

KiChjang commented Aug 26, 2016

bors-servo commented Aug 26, 2016

jdm commented Aug 26, 2016

bors-servo commented Aug 26, 2016

jdm commented Aug 26, 2016

KiChjang commented Aug 26, 2016

bors-servo commented Aug 26, 2016

bors-servo commented Aug 26, 2016

KiChjang commented Aug 26, 2016

KiChjang commented Oct 12, 2016

bors-servo commented Oct 12, 2016

bors-servo commented Oct 12, 2016

bors-servo commented Oct 12, 2016

bors-servo commented Oct 12, 2016

Manishearth commented Oct 12, 2016 •

edited

bors-servo commented Oct 12, 2016

bors-servo commented Oct 12, 2016

Manishearth commented Oct 12, 2016

bors-servo commented Oct 12, 2016

bors-servo commented Oct 12, 2016

servo / servo

Join GitHub today

Implement transition event and infrastructure #13056

Implement transition event and infrastructure #13056

Conversation

KiChjang commented Aug 26, 2016 • edited by larsbergstrom

highfive commented Aug 26, 2016

highfive commented Aug 26, 2016

KiChjang commented Aug 26, 2016

bors-servo commented Aug 26, 2016

bors-servo commented Aug 26, 2016

KiChjang commented Aug 26, 2016

bors-servo commented Aug 26, 2016

jdm commented Aug 26, 2016

bors-servo commented Aug 26, 2016

jdm commented Aug 26, 2016

KiChjang commented Aug 26, 2016

bors-servo commented Aug 26, 2016

bors-servo commented Aug 26, 2016

KiChjang commented Aug 26, 2016

KiChjang commented Oct 12, 2016

bors-servo commented Oct 12, 2016

bors-servo commented Oct 12, 2016

bors-servo commented Oct 12, 2016

bors-servo commented Oct 12, 2016

Manishearth commented Oct 12, 2016 • edited

bors-servo commented Oct 12, 2016

bors-servo commented Oct 12, 2016

Manishearth commented Oct 12, 2016

bors-servo commented Oct 12, 2016

bors-servo commented Oct 12, 2016

KiChjang commented Aug 26, 2016 •

edited by larsbergstrom

Manishearth commented Oct 12, 2016 •

edited