Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the JSAutoCompartment from report_pending_exception. #13057

Merged
merged 1 commit into from Aug 27, 2016
Merged

Remove the JSAutoCompartment from report_pending_exception. #13057

merged 1 commit into from Aug 27, 2016
+11 −10

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 26, 2016 •
edited by larsbergstrom

This change is Reviewable
@Ms2ger
Remove the JSAutoCompartment from report_pending_exception.
Loading status checks…
5662f0d 
It doesn't really belong there.
@highfive
Copy link

highfive commented Aug 26, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/workerglobalscope.rs, components/script/dom/window.rs, components/script/dom/bindings/callback.rs, components/script/dom/eventtarget.rs, components/script/dom/bindings/error.rs
@highfive
Copy link

highfive commented Aug 26, 2016

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!
@KiChjang
Copy link
Member

KiChjang commented Aug 26, 2016

r? @nox
@highfive highfive assigned nox and unassigned KiChjang Aug 26, 2016
@nox
Copy link
Member

nox commented Aug 26, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 26, 2016

📌 Commit 5662f0d has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Aug 26, 2016

⌛ Testing commit 5662f0d with merge 5dee4fc...
bors-servo added a commit that referenced this pull request Aug 26, 2016
@bors-servo
Auto merge of #13057 - servo:rpe-ac, r=nox
Loading status checks…
5dee4fc 
Remove the JSAutoCompartment from report_pending_exception.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13057)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 26, 2016

💔 Test failed - mac-rel-wpt
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Aug 27, 2016

@bors-servo retry #11618
@bors-servo
Copy link
Contributor

bors-servo commented Aug 27, 2016

⌛ Testing commit 5662f0d with merge 0be94bb...
bors-servo added a commit that referenced this pull request Aug 27, 2016
@bors-servo
Auto merge of #13057 - servo:rpe-ac, r=nox
Loading status checks…
0be94bb 
Remove the JSAutoCompartment from report_pending_exception.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13057)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 27, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit 5662f0d into master Aug 27, 2016
3 of 4 checks passed
3 of 4 checks passed
dependency-ci Failed dependency checks
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the rpe-ac branch Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @KiChjang @nox @bors-servo
You can’t perform that action at this time.