Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DOMJSClass use JSClass instead of Class (fixes #13031) #13062

Merged
merged 1 commit into from Aug 27, 2016
Merged

Make DOMJSClass use JSClass instead of Class (fixes #13031) #13062

merged 1 commit into from Aug 27, 2016

Conversation

@nox
Copy link
Member

nox commented Aug 26, 2016 •
edited by larsbergstrom

This change is Reviewable
@tetsuharuohzeki @nox
Make DOMJSClass use JSClass instead of Class (fixes #13031)
Loading status checks…
0277cf9
@highfive
Copy link

highfive commented Aug 26, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/browsingcontext.rs, components/script/dom/bindings/utils.rs
@highfive
Copy link

highfive commented Aug 26, 2016

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nox nox mentioned this pull request Aug 26, 2016
Closed
@nox
Copy link
Member Author

nox commented Aug 26, 2016

@bors-servo r+
@highfive highfive assigned nox and unassigned pcwalton Aug 26, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Aug 26, 2016

📌 Commit 0277cf9 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Aug 26, 2016

⌛ Testing commit 0277cf9 with merge 92776b0...
bors-servo added a commit that referenced this pull request Aug 26, 2016
@bors-servo
Auto merge of #13062 - nox:bump-js, r=nox
Loading status checks…
92776b0 
Make DOMJSClass use JSClass instead of Class (fixes #13031)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13062)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 26, 2016

💔 Test failed - linux-rel
@nox
Copy link
Member Author

nox commented Aug 26, 2016

@bors-servo retry #11772
@bors-servo
Copy link
Contributor

bors-servo commented Aug 27, 2016

⌛ Testing commit 0277cf9 with merge fe1225b...
bors-servo added a commit that referenced this pull request Aug 27, 2016
@bors-servo
Auto merge of #13062 - nox:bump-js, r=nox
Loading status checks…
fe1225b 
Make DOMJSClass use JSClass instead of Class (fixes #13031)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13062)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 27, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit 0277cf9 into servo:master Aug 27, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Aug 27, 2016
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @highfive @bors-servo @pcwalton @tetsuharuohzeki
You can’t perform that action at this time.