Skip to content

Comments

Convert imports in generate_imports into one per line, so that it can…#13070

Merged
bors-servo merged 1 commit intoservo:masterfrom
tp6vup54:master
Aug 27, 2016
Merged

Convert imports in generate_imports into one per line, so that it can…#13070
bors-servo merged 1 commit intoservo:masterfrom
tp6vup54:master

Conversation

@tp6vup54
Copy link
Contributor

@tp6vup54 tp6vup54 commented Aug 27, 2016

Convert imports in generate_imports into one per line, so that it can easily add new ones with alphabetical order.


  • There are tests for these changes OR
  • These changes do not require tests because _____

… easily add new ones with alphabetical order.


This change is Reviewable

'js::error::throw_type_error',
'js::jsapi::JSContext',
'js::jsapi::{HandleValue, MutableHandleValue}',
'js::jsapi::HandleValue',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this line should be above the previous line.

@jdm jdm added the S-awaiting-review There is new code that needs to be reviewed. label Aug 27, 2016
'js::jsapi::JS_SetImmutablePrototype',
'js::jsapi::JS_SetProperty',
'js::jsapi::JS_SetReservedSlot',
'js::jsapi::JS_SplicePrototype',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same problem as above - _ is greater than any Latin capital letters.

@KiChjang KiChjang added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 27, 2016
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Aug 27, 2016
@KiChjang
Copy link
Contributor

Looks great! All that's left now is to squash your commits into one.

@KiChjang KiChjang added S-needs-squash Some (or all) of the commits in the PR should be combined. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 27, 2016
… easily add new ones with alphabetical order.
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 27, 2016
@shinglyu shinglyu modified the milestone: Taiwan Code Sprint Aug 27, 2016
@jdm
Copy link
Member

jdm commented Aug 27, 2016

@bors-servo: r=KiChjang

@bors-servo
Copy link
Contributor

📌 Commit 59dcb31 has been approved by KiChjang

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. S-needs-squash Some (or all) of the commits in the PR should be combined. labels Aug 27, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 59dcb31 with merge 85838c0...

bors-servo pushed a commit that referenced this pull request Aug 27, 2016
Convert imports in generate_imports into one per line, so that it can…

<!-- Please describe your changes on the following line: -->
Convert imports in generate_imports into one per line, so that it can easily add new ones with alphabetical order.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13036 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

… easily add new ones with alphabetical order.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13070)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt

@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 27, 2016
@highfive
Copy link

  ▶ TIMEOUT [expected PASS] /_mozilla/css/iframe/hide_layers2.html

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Aug 27, 2016
@KiChjang
Copy link
Contributor

@bors-servo
Copy link
Contributor

⌛ Testing commit 59dcb31 with merge 1fd2577...

bors-servo pushed a commit that referenced this pull request Aug 27, 2016
Convert imports in generate_imports into one per line, so that it can…

<!-- Please describe your changes on the following line: -->
Convert imports in generate_imports into one per line, so that it can easily add new ones with alphabetical order.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13036 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

… easily add new ones with alphabetical order.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13070)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Aug 27, 2016
@bors-servo
Copy link
Contributor

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev

@bors-servo bors-servo merged commit 59dcb31 into servo:master Aug 27, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert imports in generate_imports into one per line

6 participants