Convert imports in generate_imports into one per line, so that it can…#13070
Merged
bors-servo merged 1 commit intoservo:masterfrom Aug 27, 2016
Merged
Convert imports in generate_imports into one per line, so that it can…#13070bors-servo merged 1 commit intoservo:masterfrom
bors-servo merged 1 commit intoservo:masterfrom
Conversation
| 'js::error::throw_type_error', | ||
| 'js::jsapi::JSContext', | ||
| 'js::jsapi::{HandleValue, MutableHandleValue}', | ||
| 'js::jsapi::HandleValue', |
Contributor
There was a problem hiding this comment.
Looks like this line should be above the previous line.
| 'js::jsapi::JS_SetImmutablePrototype', | ||
| 'js::jsapi::JS_SetProperty', | ||
| 'js::jsapi::JS_SetReservedSlot', | ||
| 'js::jsapi::JS_SplicePrototype', |
Contributor
There was a problem hiding this comment.
Same problem as above - _ is greater than any Latin capital letters.
KiChjang
added
S-needs-code-changes
highfive
added
S-awaiting-review
Contributor
|
Looks great! All that's left now is to squash your commits into one. |
KiChjang
added
S-needs-squash
… easily add new ones with alphabetical order.
highfive
added
the
S-awaiting-review
Member
|
@bors-servo: r=KiChjang |
Contributor
|
📌 Commit 59dcb31 has been approved by |
highfive
added
S-awaiting-merge
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Aug 27, 2016
Convert imports in generate_imports into one per line, so that it can… <!-- Please describe your changes on the following line: --> Convert imports in generate_imports into one per line, so that it can easily add new ones with alphabetical order. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #13036 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> … easily add new ones with alphabetical order. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13070) <!-- Reviewable:end -->
Contributor
|
💔 Test failed - mac-rel-wpt |
highfive
removed
the
S-awaiting-merge
|
Contributor
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Aug 27, 2016
Convert imports in generate_imports into one per line, so that it can… <!-- Please describe your changes on the following line: --> Convert imports in generate_imports into one per line, so that it can easily add new ones with alphabetical order. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #13036 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> … easily add new ones with alphabetical order. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13070) <!-- Reviewable:end -->
highfive
added
S-awaiting-merge
Contributor
|
☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev |
highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert imports in generate_imports into one per line, so that it can easily add new ones with alphabetical order.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors… easily add new ones with alphabetical order.
This change is