Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove unnecessary clone from ServiceWorkerManager::prepare_activation #13076
+2
−2
Conversation
highfive
commented
Aug 27, 2016
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @asajeffrey (or someone else) soon. |
highfive
commented
Aug 27, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Aug 27, 2016
|
@bors-servo: r+ |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 27, 2016
Remove unnecessary clone from ServiceWorkerManager::prepare_activation remove unnecessary for `scope_url` - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12999 - [X] These changes do not require tests because it should works when it compiles <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13076) <!-- Reviewable:end -->
|
|
|
I don't see why this will fail... @jdm idea?
|
|
|
@bors-servo retry |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 27, 2016
Remove unnecessary clone from ServiceWorkerManager::prepare_activation remove unnecessary for `scope_url` - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12999 - [X] These changes do not require tests because it should works when it compiles <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13076) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
wdv4758h commentedAug 27, 2016
•
edited by larsbergstrom
remove unnecessary for
scope_url./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is