Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary clone from ServiceWorkerManager::prepare_activation #13076

Merged
merged 1 commit into from Aug 27, 2016

Conversation

@wdv4758h
Copy link
Contributor

wdv4758h commented Aug 27, 2016

remove unnecessary for scope_url

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #12999
  • These changes do not require tests because it should works when it compiles

This change is Reviewable

@highfive
Copy link

highfive commented Aug 27, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @asajeffrey (or someone else) soon.

@highfive
Copy link

highfive commented Aug 27, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/serviceworker_manager.rs
@highfive
Copy link

highfive commented Aug 27, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Aug 27, 2016

@bors-servo: r+
Thanks!

@bors-servo
Copy link
Contributor

bors-servo commented Aug 27, 2016

📌 Commit 10cf2ee has been approved by jdm

@highfive highfive assigned jdm and unassigned asajeffrey Aug 27, 2016
@shinglyu shinglyu modified the milestone: Taiwan Code Sprint Aug 27, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Aug 27, 2016

Testing commit 10cf2ee with merge d93597c...

bors-servo added a commit that referenced this pull request Aug 27, 2016
Remove unnecessary clone from ServiceWorkerManager::prepare_activation

remove unnecessary for `scope_url`

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12999
- [X] These changes do not require tests because it should works when it compiles

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13076)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 27, 2016

💔 Test failed - mac-rel-wpt

@izgzhen
Copy link
Contributor

izgzhen commented Aug 27, 2016

I don't see why this will fail... @jdm idea?

{"status": "TIMEOUT", "line": 20933, "subtest": null, "action": "test_result", "test": "/XMLHttpRequest/send-usp.worker", "message": null, "stack": null, "expected": "OK"}
@KiChjang
Copy link
Member

KiChjang commented Aug 27, 2016

Ran 6850 tests finished in 2126.0 seconds.
  • 6849 ran as expected. 1660 tests skipped.
  • 1 tests timed out unexpectedly

Tests with unexpected results:
  ▶ TIMEOUT [expected OK] /XMLHttpRequest/send-usp.worker
  │ 
  │ Stack trace for thread "ScriptThread PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(0) }"
  │ stack backtrace:
  │    0:        0x110b5469e - backtrace::backtrace::trace::h22a738598d75d447
  │    1:        0x110b549ac - backtrace::capture::Backtrace::new::h1a277804460ccff5
  │    2:        0x10f2a0898 - servo::install_crash_handler::handler::h7d01d896c8f0d15d
  │    3:     0x7fff9852df19 - _sigtramp
  │    4:        0x110197e3f - 13JSCompartment4wrapEP9JSContextN2JS13MutableHandleIP8JSObjectEENS2_6HandleIS5_E
  │    5:        0x1101757dd - 13JSCompartment4wrapEP9JSContextN2JS13MutableHandleINS2_5ValueEEENS2_6HandleIP8JSObjectE
  │    6:        0x11015c644 - _Z12JS_WrapValueP9JSContextN2JS13MutableHandleINS1_5ValueEEE
  │    7:        0x10f7a8ac8 - std::panicking::try::do_call::h7f1663ddafd7ad43
  │    8:        0x110beb22a - __rust_maybe_catch_panic
  │    9:        0x10fa849d7 - script::dom::bindings::codegen::Bindings::MessageEventBinding::MessageEventBinding::get_data::h9dcb7acd957cbcbf
  │ Stack trace for thread "ScriptThread PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(0) }"
  │ stack backtrace:
  │    0:        0x110b5469e - backtrace::backtrace::trace::h22a738598d75d447
  │    1:        0x110b549ac - backtrace::capture::Backtrace::new::h1a277804460ccff5
  │    2:        0x10f2a0898 - servo::install_crash_handler::handler::h7d01d896c8f0d15d
  │    3:     0x7fff9852df19 - _sigtramp
  │    4:        0x10f2a091c - servo::install_crash_handler::handler::h7d01d896c8f0d15d
  │    5:     0x7fff9852df19 - _sigtramp
  │    6:        0x110197e3f - 13JSCompartment4wrapEP9JSContextN2JS13MutableHandleIP8JSObjectEENS2_6HandleIS5_E
  │    7:        0x1101757dd - 13JSCompartment4wrapEP9JSContextN2JS13MutableHandleINS2_5ValueEEENS2_6HandleIP8JSObjectE
  │    8:        0x11015c644 - _Z12JS_WrapValueP9JSContextN2JS13MutableHandleINS1_5ValueEEE
  │    9:        0x10f7a8ac8 - std::panicking::try::do_call::h7f1663ddafd7ad43
  │   10:        0x110beb22a - __rust_maybe_catch_panic
  └   11:        0x10fa849d7 - script::dom::bindings::codegen::Bindings::MessageEventBinding::MessageEventBinding::get_data::h9dcb7acd957cbcbf
@KiChjang
Copy link
Member

KiChjang commented Aug 27, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Aug 27, 2016

Testing commit 10cf2ee with merge a0f45c6...

bors-servo added a commit that referenced this pull request Aug 27, 2016
Remove unnecessary clone from ServiceWorkerManager::prepare_activation

remove unnecessary for `scope_url`

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12999
- [X] These changes do not require tests because it should works when it compiles

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13076)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 27, 2016

@bors-servo bors-servo merged commit 10cf2ee into servo:master Aug 27, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Aug 27, 2016
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

8 participants
You can’t perform that action at this time.