Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update offscreen_gl_context. Fixes #12320 #13085

Merged
merged 1 commit into from Aug 29, 2016
Merged

Update offscreen_gl_context. Fixes #12320 #13085

merged 1 commit into from Aug 29, 2016

Conversation

@emilio
Copy link
Member

emilio commented Aug 28, 2016 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #12320 (github issue number if applicable).
  • There are tests for these changes OR

This change is Reviewable
@emilio
Copy link
Member Author

emilio commented Aug 28, 2016

r? @jdm (or anyone really)

@bors-servo: try

(just in case this fixes any WebGL crash).
@highfive highfive assigned jdm and unassigned metajack Aug 28, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Aug 28, 2016

⌛ Trying commit 22a7a50 with merge 26c9e3d...
bors-servo added a commit that referenced this pull request Aug 28, 2016
@bors-servo
Auto merge of #13085 - emilio:gl-up, r=<try>
Loading status checks…
26c9e3d 
Update offscreen_gl_context. Fixes #12320

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #12320 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13085)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 28, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@KiChjang
Copy link
Member

KiChjang commented Aug 28, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 28, 2016

📌 Commit 22a7a50 has been approved by KiChjang
@highfive highfive assigned KiChjang and unassigned jdm Aug 28, 2016
@emilio
Copy link
Member Author

emilio commented Aug 29, 2016 •
edited

@bors-servo: r=KiChjang
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2016

📌 Commit 22a7a50 has been approved by KiChjang
@KiChjang
Copy link
Member

KiChjang commented Aug 29, 2016

@bors-servo try- clean retry r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2016

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #12989
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2016

📌 Commit 22a7a50 has been approved by KiChjang
bors-servo added a commit that referenced this pull request Aug 29, 2016
@bors-servo
Auto merge of #13085 - emilio:gl-up, r=KiChjang
Loading status checks…
e2103d6 
Update offscreen_gl_context. Fixes #12320

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #12320 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13085)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2016

⌛ Testing commit 22a7a50 with merge e2103d6...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2016

💔 Test failed - linux-dev
@nox
Copy link
Member

nox commented Aug 29, 2016

@emilio Seems like you did this PR pre-cargoup, thus the metadata bits weren't properly updated. Just rebase and do ./mach cargo-update -p offscreen_gl_context and it should be ok.
@emilio
Update offscreen_gl_context. Fixes #12320
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
bede959
@emilio emilio force-pushed the emilio:gl-up branch from 22a7a50 to bede959 Aug 29, 2016
@emilio
Copy link
Member Author

emilio commented Aug 29, 2016

@bors-servo: r=KiChjang
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2016

📌 Commit bede959 has been approved by KiChjang
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2016

⌛ Testing commit bede959 with merge 7ebdf98...
bors-servo added a commit that referenced this pull request Aug 29, 2016
@bors-servo
Auto merge of #13085 - emilio:gl-up, r=KiChjang
Loading status checks…
7ebdf98 
Update offscreen_gl_context. Fixes #12320

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #12320 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13085)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit bede959 into servo:master Aug 29, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Aug 29, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KiChjang KiChjang

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Shadertoy claims webgl is missing
7 participants
@emilio @bors-servo @KiChjang @nox @jdm @metajack @highfive
You can’t perform that action at this time.