Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded clone in the style system cache #13093

Merged
merged 1 commit into from Aug 28, 2016

Conversation

@ashrwin
Copy link
Contributor

ashrwin commented Aug 28, 2016


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #13089 (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests.

This change is Reviewable

@highfive
Copy link

highfive commented Aug 28, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/matching.rs
@highfive
Copy link

highfive commented Aug 28, 2016

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member

nox commented Aug 28, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Aug 28, 2016

📌 Commit 84eab31 has been approved by nox

@highfive highfive assigned nox and unassigned glennw Aug 28, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Aug 28, 2016

Testing commit 84eab31 with merge db52d8a...

bors-servo added a commit that referenced this pull request Aug 28, 2016
Remove unneeded clone in the style system cache

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13089  (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13093)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 28, 2016

@bors-servo bors-servo merged commit 84eab31 into servo:master Aug 28, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.