Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Option<T> to return from getters #13100

Merged
merged 6 commits into from Aug 31, 2016
Merged

Use Option<T> to return from getters #13100

merged 6 commits into from Aug 31, 2016
+164 −154

Conversation

@nox
Copy link
Member

nox commented Aug 28, 2016 •
edited by larsbergstrom

This change is Reviewable
@highfive
Copy link

highfive commented Aug 28, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/htmlcollection.rs, components/script/dom/textencoder.rs, components/script/dom/crypto.rs, components/script/dom/htmlcanvaselement.rs, components/script/dom/document.rs, components/script/dom/testbinding.rs, components/script/dom/cssstyledeclaration.rs, components/script/dom/mimetypearray.rs, components/script/dom/htmlformcontrolscollection.rs, components/script/dom/pluginarray.rs, components/script/dom/imagedata.rs, components/script/dom/domstringmap.rs, components/script/dom/bindings/iterable.rs, components/script/dom/touchlist.rs, components/script/dom/filelist.rs, components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/namednodemap.rs, components/script/dom/domrectlist.rs, components/script/dom/testbindingproxy.rs, components/script/dom/stylesheetlist.rs, components/script/dom/testbindingiterable.rs, components/script/dom/storage.rs, components/script/dom/canvasrenderingcontext2d.rs, components/script/dom/radionodelist.rs, components/script/dom/xmldocument.rs, components/script/dom/htmlformelement.rs, components/script/dom/webglrenderingcontext.rs, components/script/dom/domtokenlist.rs, components/script/dom/nodelist.rs, components/script/dom/plugin.rs
  • @emilio: components/script/dom/webglrenderingcontext.rs
@highfive
Copy link

highfive commented Aug 28, 2016

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member Author

nox commented Aug 28, 2016

servo/rust-mozjs#299
@nox
Copy link
Member Author

nox commented Aug 29, 2016

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2016

⌛ Trying commit 264fe4d with merge e891c6f...
bors-servo added a commit that referenced this pull request Aug 29, 2016
@bors-servo
Auto merge of #13100 - nox:better-getters, r=<try>
Loading status checks…
e891c6f 
Use Option<T> to return from getters

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13100)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
nox added 6 commits Aug 28, 2016
@nox
Assert that ImageData::data is not null
854a3df
@nox
Don't bother with the global in ImageData::get_image_data
2400b91
@nox
Improve some TestBinding methods
897a81e 
We make them return sensical things in a sensical way.
@nox
Root js_object in TextEncoder::Encode
3e32948
@nox
Compile WebIDL return type "object" to NonZero<*mut JSObject>
6e1523f
@nox
Use Option<T> to return from getters
Loading status checks…
7dfb336 
This removes the cumbersome &mut bool argument and offers overall
a more readable code.
@nox nox force-pushed the nox:better-getters branch from 264fe4d to 7dfb336 Aug 30, 2016
@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 31, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2016

📌 Commit 7dfb336 has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2016

⌛ Testing commit 7dfb336 with merge 3649a35...
bors-servo added a commit that referenced this pull request Aug 31, 2016
@bors-servo
Auto merge of #13100 - nox:better-getters, r=Ms2ger
Loading status checks…
3649a35 
Use Option<T> to return from getters

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13100)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit 7dfb336 into servo:master Aug 31, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@nox @highfive @bors-servo @Ms2ger
You can’t perform that action at this time.