Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Option<T> to return from getters #13100

Merged
merged 6 commits into from Aug 31, 2016
Merged

Use Option<T> to return from getters #13100

merged 6 commits into from Aug 31, 2016

Commits on Aug 30, 2016

  1. Assert that ImageData::data is not null

    @nox
    nox committed Aug 30, 2016
    854a3df

  2. Don't bother with the global in ImageData::get_image_data

    @nox
    nox committed Aug 30, 2016
    2400b91

  3. Improve some TestBinding methods 

    We make them return sensical things in a sensical way.
    @nox
    nox committed Aug 30, 2016
    897a81e

  4. Root js_object in TextEncoder::Encode

    @nox
    nox committed Aug 30, 2016
    3e32948

  5. Compile WebIDL return type "object" to NonZero<*mut JSObject>

    @nox
    nox committed Aug 30, 2016
    6e1523f

  6. Use Option<T> to return from getters 

    This removes the cumbersome &mut bool argument and offers overall
a more readable code.
    @nox
    nox committed Aug 30, 2016
    Loading status checks…
    7dfb336
You can’t perform that action at this time.