Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAvoid LLVM prepending "_" for msvc32 symbols. #13116
Merged
Conversation
|
Sigh, windows... Thanks for digging into this Xidorn! @bors-servo: r+ |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 30, 2016
Avoid LLVM prepending "_" for msvc32 symbols. See rust-lang/rust#36097. This patch adds a workaround to that issue, which makes win32 stylo build. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13116) <!-- Reviewable:end -->
|
|
highfive
commented
Aug 30, 2016
|
|
@bors-servo retry #13059 |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
upsuper commentedAug 30, 2016
•
edited by larsbergstrom
See rust-lang/rust#36097. This patch adds a workaround to that issue, which makes win32 stylo build.
This change is