Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upstyle: Properly track whether negative values of calc() are allowed #13121
Conversation
|
@bors-servo: try |
|
|
style: Properly track whether negative values of calc() are allowed <!-- Please describe your changes on the following line: --> r? @SimonSapin --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Either: --> - [x] There are tests for these changes OR <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> In order to clamp them at computed value time.
|
|
|
https://drafts.csswg.org/css-values/#calc-range
(Emphasis added.) So I’d suggest adding a method on the computed-value-types that layout can call. And maybe make some fields private to force it to go through that method? |
|
|
In order to clamp them at computed value time.
|
For the record, I opened a spec issue about this. w3c/csswg-drafts#434 |
|
Apparently this matches WebKit and Blink: w3c/csswg-drafts#434 (comment) @bors-servo r+ |
|
|
style: Properly track whether negative values of calc() are allowed <!-- Please describe your changes on the following line: --> r? @SimonSapin --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Either: --> - [x] There are tests for these changes OR <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> In order to clamp them at computed value time. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13121) <!-- Reviewable:end -->
|
|
|
This was still wrong, my fault. |
emilio commentedAug 30, 2016
•
edited by larsbergstrom
r? @SimonSapin
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsIn order to clamp them at computed value time.
This change is