Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix debug assertion introduced in #13108 by me. #13128
Merged
Conversation
I'm stupid, and when I did the last moving-the-code-around, I failed miserably to double-check it in a debug build.
highfive
commented
Aug 30, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Aug 30, 2016
|
|
|
r? @nox |
|
@bors-servo: p=1
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 30, 2016
Fix debug assertion introduced in #13108 by me. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13125 (github issue number if applicable). <!-- Either: --> - [x] These changes do not require tests because #13127 <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> I'm stupid, and when I did the last moving-the-code-around, I failed miserably to double-check it in a debug build. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13128) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emilio commentedAug 30, 2016
•
edited by larsbergstrom
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsI'm stupid, and when I did the last moving-the-code-around, I failed miserably
to double-check it in a debug build.
This change is