Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lots of Arc’s in style, and prepare for using DOMRefCell #13134

Merged
merged 11 commits into from Aug 31, 2016
Merged

Commits on Aug 31, 2016

  1. Remove CSSRule::Charset

    `@charset` rules are not reflected in CSSOM.
    SimonSapin committed Aug 31, 2016
  2. Move DOMRefCell to style.

    SimonSapin committed Aug 31, 2016
  3. Prepare for interior mutability in PropertyDeclarationBlock

    `Stylist` contains separate hashmaps for important and normal declarations,
    but typically a given block only contains declarations of one importance.
    
    Before this commit, there is an optimization where
    a `PropertyDeclarationBlock` is only inserted in the corresponding map
    if it has a non-zero number of declaration of a given importance.
    
    With CSSOM, `PropertyDeclarationBlock` is gonna have interior mutability:
    the importance (priority) of a declaration could change.
    This optimization would become incorrect when the block is missing
    in a hashmap where it should be.
    
    This commits removes the original optimization, and replaces it with
    a slightly weaker one: if a block doesn’t have any declaration
    with the importance we’re cascading for, skip selector matching.
    SimonSapin committed Aug 31, 2016
You can’t perform that action at this time.