Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for the exact timing of the error event for invalid event … #13136

Merged
merged 1 commit into from Aug 31, 2016
Merged

Add a test for the exact timing of the error event for invalid event … #13136

merged 1 commit into from Aug 31, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 31, 2016 •
edited by larsbergstrom

This change is Reviewable
@nox
Copy link
Member

nox commented Aug 31, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2016

📌 Commit 6ecc0e2 has been approved by nox
@highfive highfive assigned nox and unassigned larsbergstrom Aug 31, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2016

⌛ Testing commit 6ecc0e2 with merge d07aa10...
bors-servo added a commit that referenced this pull request Aug 31, 2016
@bors-servo
Auto merge of #13136 - servo:error-test, r=nox
Loading status checks…
d07aa10 
Add a test for the exact timing of the error event for invalid event …

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13136)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2016

💔 Test failed - arm32
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Aug 31, 2016

@bors-servo retry

  • network issue
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2016

⚡ Previous build results for arm64, linux-dev, mac-dev-unit, windows-dev are reusable. Rebuilding only arm32, linux-rel, mac-rel-css, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2016

💔 Test failed - mac-rel-wpt
@highfive
Copy link

highfive commented Aug 31, 2016 

  ▶ Unexpected subtest result in /html/webappapis/scripting/events/invalid-uncompiled-raw-handler-compiled-late.html:
  │ FAIL [expected PASS] Invalid uncompiled raw handlers should only be compiled when about to call them.
  │   → assert_array_equals: lengths differ, expected 3 got 2
  │ 
  │ @http://web-platform.test:8000/html/webappapis/scripting/events/invalid-uncompiled-raw-handler-compiled-late.html:16:3
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1403:20
  │ test@http://web-platform.test:8000/resources/testharness.js:501:9
  └ @http://web-platform.test:8000/html/webappapis/scripting/events/invalid-uncompiled-raw-handler-compiled-late.html:4:1
@Ms2ger
Add a test for the exact timing of the error event for invalid event …
Loading status checks…
aeb6b17 
…handlers.
@Ms2ger Ms2ger force-pushed the error-test branch from 6ecc0e2 to aeb6b17 Aug 31, 2016
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Aug 31, 2016

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2016

📌 Commit aeb6b17 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2016

⌛ Testing commit aeb6b17 with merge 6d920f3...
bors-servo added a commit that referenced this pull request Aug 31, 2016
@bors-servo
Auto merge of #13136 - servo:error-test, r=nox
Loading status checks…
6d920f3 
Add a test for the exact timing of the error event for invalid event …

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13136)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Aug 31, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform3d-translatez-001.htm
  └   → /css-transforms-1_dev/html/transform3d-translatez-001.htm 902d90a8d198625335e738587fdfe81dcc90392d
/css-transforms-1_dev/html/reference/transform3d-translatez-ref.htm b14318ccfd8a59b7b249d41521e178d617678823
Testing 902d90a8d198625335e738587fdfe81dcc90392d == b14318ccfd8a59b7b249d41521e178d617678823
/css-transforms-1_dev/html/transform3d-translatez-001.htm 902d90a8d198625335e738587fdfe81dcc90392d
/css-transforms-1_dev/html/reference/transform3d-translatez-notref.htm 902d90a8d198625335e738587fdfe81dcc90392d
Testing 902d90a8d198625335e738587fdfe81dcc90392d != 902d90a8d198625335e738587fdfe81dcc90392d
@nox
Copy link
Member

nox commented Aug 31, 2016

@bors-servo retry #11631
@nox nox added S-awaiting-merge and removed S-tests-failed labels Aug 31, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2016

⌛ Testing commit aeb6b17 with merge 59a0be0...
bors-servo added a commit that referenced this pull request Aug 31, 2016
@bors-servo
Auto merge of #13136 - servo:error-test, r=nox
Loading status checks…
59a0be0 
Add a test for the exact timing of the error event for invalid event …

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13136)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit aeb6b17 into master Aug 31, 2016
3 of 4 checks passed
3 of 4 checks passed
dependency-ci Failed dependency checks
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the error-test branch Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @nox @bors-servo @highfive @larsbergstrom
You can’t perform that action at this time.