Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't use mem::uninitialized() for making calc values #13148
Merged
Conversation
highfive
commented
Sep 1, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Sep 1, 2016
|
|
| pub fn null() -> Self { | ||
| // can't construct directly because it has private | ||
| // fields | ||
| let mut coord: Self = unsafe { mem::zeroed() }; |
This comment has been minimized.
This comment has been minimized.
emilio
Sep 2, 2016
Member
/me mutters something about accessors...
Is the wrapping of the comment intentionally at ~65 chars?
r=me when it's ready, ideally with the proper wrapping and capitalization in the comment
|
@bors-servo r=emilio |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 2, 2016
Don't use mem::uninitialized() for making calc values We had code relying on `nsStyleCoord::set()` being leaky (like it was before we patched up the calc bindings). Added `nsStyleCoord::null()` for this use case since it's not possible to construct directly anymore. r? @emilio <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13148) <!-- Reviewable:end -->
We had code relying on `nsStyleCoord::set()` being leaky (like it was before we patched up the calc bindings). Added `nsStyleCoord::null()` for this use case since it's not possible to construct directly anymore.
|
|
highfive
commented
Sep 2, 2016
|
|
@bors-servo retry |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedSep 1, 2016
•
edited by larsbergstrom
We had code relying on
nsStyleCoord::set()being leaky (like it wasbefore we patched up the calc bindings). Added
nsStyleCoord::null()forthis use case since it's not possible to construct directly anymore.
r? @emilio
This change is