Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Don't incorrectly clamp values in calc that might not be only lengths. #13159

Merged
merged 1 commit into from Sep 2, 2016
Merged

style: Don't incorrectly clamp values in calc that might not be only lengths. #13159

merged 1 commit into from Sep 2, 2016

Conversation

@emilio
Copy link
Member

emilio commented Sep 1, 2016 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR

This change is Reviewable
@highfive
Copy link

highfive commented Sep 1, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/media_queries.rs, components/style/values/specified/mod.rs, components/style/values/computed/mod.rs
@emilio
Copy link
Member Author

emilio commented Sep 1, 2016

r? @SimonSapin
@highfive highfive assigned SimonSapin and unassigned jdm Sep 1, 2016
@emilio
style: Don't incorrectly clamp values in calc that might not be only …
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
d02c5b0 
…lengths.

Expressions with percentages may be negative or positive at computed value time.

So, we can only clamp lengths at computed value time, which is what the other
browsers do.
@emilio emilio force-pushed the emilio:negative-calc branch from 3b41280 to d02c5b0 Sep 2, 2016
@notriddle
Copy link
Contributor

notriddle commented Sep 2, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 2, 2016

📌 Commit d02c5b0 has been approved by notriddle
@highfive highfive assigned notriddle and unassigned SimonSapin Sep 2, 2016
bors-servo added a commit that referenced this pull request Sep 2, 2016
@bors-servo
Auto merge of #13159 - emilio:negative-calc, r=notriddle
Loading status checks…
51bb125 
style: Don't incorrectly clamp values in calc that might not be only lengths.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13159)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 2, 2016

⌛ Testing commit d02c5b0 with merge 51bb125...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 2, 2016

💔 Test failed - mac-rel-wpt
@highfive
Copy link

highfive commented Sep 2, 2016 

  ▶ ERROR [expected OK] /webgl/conformance-1.0.3/conformance/ogles/GL/build/build_001_to_008.html
  └   → gl.getProgramInfoLog is not a function
@emilio
Copy link
Member Author

emilio commented Sep 2, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 2, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 2, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit d02c5b0 into servo:master Sep 2, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@emilio emilio deleted the emilio:negative-calc branch Sep 2, 2016
@emilio emilio mentioned this pull request Sep 2, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@emilio @highfive @notriddle @bors-servo @jdm @SimonSapin
You can’t perform that action at this time.