Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update string_cache to 0.2.27 #13170

Merged
merged 1 commit into from Sep 4, 2016
Merged

Update string_cache to 0.2.27 #13170

merged 1 commit into from Sep 4, 2016

Conversation

@KiChjang
Copy link
Member

KiChjang commented Sep 3, 2016 •
edited by larsbergstrom

  • ./mach build -d does not report any hahahas
  • ./mach test-tidy does not report any hahahas
  • These changes fix #hahaha (github issue number if applicable).
  • There are tests for these changes OR hahaha
  • These changes do not require tests because hahahaha

This change is Reviewable
@KiChjang KiChjang force-pushed the KiChjang:string-cache-update branch from c0662c9 to 801d2da Sep 3, 2016
@KiChjang
Update string_cache to 0.2.27
Loading status checks…
801d2da
@frewsxcv
Copy link
Member

frewsxcv commented Sep 3, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 3, 2016

📌 Commit 801d2da has been approved by frewsxcv
@highfive highfive assigned frewsxcv and unassigned cbrewster Sep 3, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Sep 3, 2016

⌛ Testing commit 801d2da with merge 04dbfe6...
bors-servo added a commit that referenced this pull request Sep 3, 2016
@bors-servo
Auto merge of #13170 - KiChjang:string-cache-update, r=frewsxcv
Loading status checks…
04dbfe6 
Update string_cache to 0.2.27

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any hahahas
- [ ] `./mach test-tidy` does not report any hahahas
- [ ] These changes fix #hahaha (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR hahaha
- [ ] These changes do not require tests because hahahaha

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13170)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 4, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member Author

KiChjang commented Sep 4, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 4, 2016

⚡ Previous build results for arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only linux-rel, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 4, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit 801d2da into servo:master Sep 4, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@KiChjang KiChjang deleted the KiChjang:string-cache-update branch Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frewsxcv frewsxcv

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@KiChjang @frewsxcv @bors-servo @highfive @cbrewster
You can’t perform that action at this time.