Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for error reporting in workers. #13174

Merged
merged 2 commits into from Sep 6, 2016
Merged

Prepare for error reporting in workers. #13174

merged 2 commits into from Sep 6, 2016

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Sep 5, 2016 •
edited by larsbergstrom

This change is Reviewable

@highfive
Copy link

highfive commented Sep 5, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/serviceworker.rs, components/script/dom/bindings/global.rs, components/script/dom/abstractworker.rs, components/script/dom/worker.rs, components/script/dom/bindings/error.rs

@highfive
Copy link

highfive commented Sep 5, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 5, 2016
@nox nox added S-awaiting-answer Someone asked a question that requires an answer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 6, 2016
@nox
Copy link
Contributor

nox commented Sep 6, 2016

One question but otherwise r=me.

-S-awaiting-review +S-awaiting-answer

Reviewed 2 of 2 files at r1, 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

components/script/dom/bindings/global.rs, line 295 [r1] (raw file):

        match *self {
            GlobalRef::Window(ref window) => window.report_an_error(error_info, value),
            GlobalRef::Worker(_) => (),

Will we ever report errors on Worker? If not, could we use if let here?

Comments from Reviewable

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Sep 6, 2016

@bors-servo r=nox

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

components/script/dom/bindings/global.rs, line 295 [r1] (raw file):

Previously, nox (Anthony Ramine) wrote…

Will we ever report errors on Worker? If not, could we use if let here?

Yeah, working on that right now.

Comments from Reviewable

@bors-servo
Copy link
Contributor

📌 Commit 59904e6 has been approved by nox

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-answer Someone asked a question that requires an answer. labels Sep 6, 2016
@highfive highfive assigned nox and unassigned KiChjang Sep 6, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 59904e6 with merge 20e1eec...

bors-servo pushed a commit that referenced this pull request Sep 6, 2016
Auto merge of #13174 - servo:error-workers, r=nox
20e1eec 
Prepare for error reporting in workers.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13174)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Sep 6, 2016
@highfive
Copy link

highfive commented Sep 6, 2016 

  ▶ TIMEOUT [expected PASS] /_mozilla/css/iframe/hide_layers2.html

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Sep 6, 2016

@bors-servo retry #13059

@bors-servo
Copy link
Contributor

⌛ Testing commit 59904e6 with merge 019ac5b...

bors-servo pushed a commit that referenced this pull request Sep 6, 2016
Auto merge of #13174 - servo:error-workers, r=nox
019ac5b 
Prepare for error reporting in workers.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13174)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Sep 6, 2016
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Sep 6, 2016
@highfive
Copy link

highfive commented Sep 6, 2016 

  ▶ TIMEOUT [expected PASS] /_mozilla/css/iframe/hide_layers2.html

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Sep 6, 2016

@bors-servo retry #13059

AAARGH

@bors-servo
Copy link
Contributor

⌛ Testing commit 59904e6 with merge 3631e31...

bors-servo pushed a commit that referenced this pull request Sep 6, 2016
Auto merge of #13174 - servo:error-workers, r=nox
3631e31 
Prepare for error reporting in workers.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13174)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Sep 6, 2016
@bors-servo
Copy link
Contributor

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev

@bors-servo bors-servo merged commit 59904e6 into master Sep 6, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Sep 6, 2016
This was referenced Sep 6, 2016
Merged
Merged
Closed
@SimonSapin SimonSapin deleted the error-workers branch September 7, 2016 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ms2ger @highfive @nox @bors-servo @KiChjang