Skip to content

Comments

Revert "Update WR (various reftest fixes)."#13189

Merged
bors-servo merged 1 commit intoservo:masterfrom
glennw:revert-vtf
Sep 7, 2016
Merged

Revert "Update WR (various reftest fixes)."#13189
bors-servo merged 1 commit intoservo:masterfrom
glennw:revert-vtf

Conversation

@glennw
Copy link
Member

@glennw glennw commented Sep 7, 2016 •
edited by larsbergstrom
Loading

This change is Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 7, 2016
@glennw
Copy link
Member Author

glennw commented Sep 7, 2016

The vertex texture fetch changes are causing issues on some mac machines. Revert this webrender update until I can figure out what is going on.

@glennw
Copy link
Member Author

glennw commented Sep 7, 2016

r? anyone

@Manishearth
Copy link
Member

Manishearth commented Sep 7, 2016

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2016

📌 Commit 0d1cb8d has been approved by Manishearth

@highfive highfive assigned Manishearth and unassigned metajack Sep 7, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2016

⌛ Testing commit 0d1cb8d with merge 9a1af35...

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 7, 2016
bors-servo pushed a commit that referenced this pull request Sep 7, 2016
Auto merge of #13189 - glennw:revert-vtf, r=Manishearth
9a1af35 
Revert "Update WR (various reftest fixes)."

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13189)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2016

💔 Test failed - mac-rel-wpt

@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Sep 7, 2016
@highfive
Copy link

highfive commented Sep 7, 2016 

  ▶ TIMEOUT [expected PASS] /_mozilla/css/iframe/hide_layers2.html

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Sep 7, 2016
@glennw
Copy link
Member Author

glennw commented Sep 7, 2016

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only mac-rel-wpt...

@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2016

💔 Test failed - mac-rel-wpt

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Sep 7, 2016
@highfive
Copy link

highfive commented Sep 7, 2016 

  ▶ ERROR [expected OK] /webgl/conformance-1.0.3/conformance/ogles/GL/build/build_001_to_008.html
  └   → gl.getProgramInfoLog is not a function

@glennw
Copy link
Member Author

glennw commented Sep 7, 2016

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only mac-rel-wpt...

@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2016

💔 Test failed - mac-rel-wpt

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Sep 7, 2016
@KiChjang
Copy link
Contributor

KiChjang commented Sep 7, 2016

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only mac-rel-wpt...

@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev

@bors-servo bors-servo merged commit 0d1cb8d into servo:master Sep 7, 2016
@glennw glennw deleted the revert-vtf branch December 12, 2016 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Manishearth Manishearth

Labels

S-tests-failed The changes caused existing tests to fail.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@glennw @Manishearth @bors-servo @highfive @KiChjang @metajack @gw3583