Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cssparser #13190

Merged
merged 2 commits into from Sep 8, 2016
Merged

Update cssparser #13190

merged 2 commits into from Sep 8, 2016

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Sep 7, 2016 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@highfive
Copy link

highfive commented Sep 7, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml, components/style/stylesheets.rs, components/style/font_face.rs, components/style/keyframes.rs, components/style/properties/properties.mako.rs, components/style/viewport.rs
  • @KiChjang: components/script/Cargo.toml, components/script_layout_interface/Cargo.toml
@Manishearth
Copy link
Member

Manishearth commented Sep 7, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2016

📌 Commit 54c9803 has been approved by Manishearth
@highfive highfive assigned Manishearth and unassigned metajack Sep 7, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2016

⌛ Testing commit 54c9803 with merge 9f1558a...
bors-servo added a commit that referenced this pull request Sep 7, 2016
@bors-servo
Auto merge of #13190 - servo:cssparser-up, r=Manishearth
Loading status checks…
9f1558a 
Update cssparser

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13190)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2016

💔 Test failed - linux-dev
@SimonSapin
Update cssparser
8bfe978
@SimonSapin SimonSapin force-pushed the cssparser-up branch from 54c9803 to 3f37e9c Sep 7, 2016
@SimonSapin
Copy link
Member Author

SimonSapin commented Sep 7, 2016

Updated selectors in port/cef/Cargo.lock.

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2016

📌 Commit 3f37e9c has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2016

⌛ Testing commit 3f37e9c with merge ef85e1d...
bors-servo added a commit that referenced this pull request Sep 7, 2016
@bors-servo
Auto merge of #13190 - servo:cssparser-up, r=Manishearth
Loading status checks…
ef85e1d 
Update cssparser

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13190)
<!-- Reviewable:end -->
@bors-servo bors-servo mentioned this pull request Sep 7, 2016
Merged
4 of 4 tasks complete
@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2016

💔 Test failed - mac-rel-wpt
@highfive
Copy link

highfive commented Sep 7, 2016 

  ▶ ERROR [expected OK] /webgl/conformance-1.0.3/conformance/ogles/GL/build/build_001_to_008.html
  └   → gl.getProgramInfoLog is not a function
@Manishearth
Copy link
Member

Manishearth commented Sep 8, 2016

@bors-servo retry p=10
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2016

⌛ Testing commit 3f37e9c with merge 5aba808...
bors-servo added a commit that referenced this pull request Sep 8, 2016
@bors-servo
Auto merge of #13190 - servo:cssparser-up, r=Manishearth
Loading status checks…
5aba808 
Update cssparser

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13190)
<!-- Reviewable:end -->
@SimonSapin @Ms2ger
Handle @namespace rules when parsing them rather than afterwards.
Loading status checks…
45af168 
This will avoid dealing with DOMRefCell when we add it around NamespaceRule.
@Ms2ger Ms2ger force-pushed the cssparser-up branch from 3f37e9c to 45af168 Sep 8, 2016
@Ms2ger
Copy link
Contributor

Ms2ger commented Sep 8, 2016

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2016

📌 Commit 45af168 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2016

⌛ Testing commit 45af168 with merge 5216108...
bors-servo added a commit that referenced this pull request Sep 8, 2016
@bors-servo
Auto merge of #13190 - servo:cssparser-up, r=Manishearth
Loading status checks…
5216108 
Update cssparser

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13190)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2016

💔 Test failed - mac-rel-wpt
@highfive
Copy link

highfive commented Sep 8, 2016 

  ▶ TIMEOUT [expected PASS] /_mozilla/css/iframe/hide_layers2.html
@SimonSapin
Copy link
Member Author

SimonSapin commented Sep 8, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2016

⌛ Testing commit 45af168 with merge d99d29e...
bors-servo added a commit that referenced this pull request Sep 8, 2016
@bors-servo
Auto merge of #13190 - servo:cssparser-up, r=Manishearth
Loading status checks…
d99d29e 
Update cssparser

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13190)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit 45af168 into master Sep 8, 2016
3 of 4 checks passed
3 of 4 checks passed
dependency-ci Failed dependency checks
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the cssparser-up branch Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@SimonSapin @highfive @Manishearth @bors-servo @Ms2ger @metajack
You can’t perform that action at this time.