Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly generate typedef identities in unions #13201

Merged
merged 1 commit into from Sep 10, 2016
Merged

Properly generate typedef identities in unions #13201

merged 1 commit into from Sep 10, 2016
+23 −6

Conversation

@KiChjang
Copy link
Member

KiChjang commented Sep 8, 2016 •
edited by larsbergstrom

Fixes #10605.

This change is Reviewable
@highfive
Copy link

highfive commented Sep 8, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/bindings/codegen/parser/WebIDL.py, components/script/dom/testbinding.rs, components/script/dom/webidls/TestBinding.webidl
@highfive
Copy link

highfive commented Sep 8, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@KiChjang KiChjang force-pushed the KiChjang:codegen-typedefs branch from 88444d8 to 3976d97 Sep 8, 2016
@KiChjang
Properly generate typedef identities in unions
Loading status checks…
3976d97
@nox
Copy link
Member

nox commented Sep 8, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2016

📌 Commit 3976d97 has been approved by nox
@highfive highfive assigned nox and unassigned Manishearth Sep 8, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2016

⌛ Testing commit 3976d97 with merge 18ba49e...
bors-servo added a commit that referenced this pull request Sep 9, 2016
@bors-servo
Auto merge of #13201 - KiChjang:codegen-typedefs, r=nox
Loading status checks…
18ba49e 
Properly generate typedef identities in unions

Fixes #10605.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13201)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2016

💔 Test failed - mac-rel-wpt
@highfive
Copy link

highfive commented Sep 9, 2016 

  ▶ ERROR [expected OK] /webgl/conformance-1.0.3/conformance/ogles/GL/build/build_001_to_008.html
  └   → gl.getProgramInfoLog is not a function
@nox
Copy link
Member

nox commented Sep 9, 2016

@bors-servo retry #13165
@nox nox added S-awaiting-merge and removed S-tests-failed labels Sep 9, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2016

⌛ Testing commit 3976d97 with merge 75718aa...
bors-servo added a commit that referenced this pull request Sep 9, 2016
@bors-servo
Auto merge of #13201 - KiChjang:codegen-typedefs, r=nox
Loading status checks…
75718aa 
Properly generate typedef identities in unions

Fixes #10605.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13201)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2016

💔 Test failed - arm64
@KiChjang
Copy link
Member Author

KiChjang commented Sep 9, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2016

⌛ Testing commit 3976d97 with merge 514d1f2...
bors-servo added a commit that referenced this pull request Sep 9, 2016
@bors-servo
Auto merge of #13201 - KiChjang:codegen-typedefs, r=nox
Loading status checks…
514d1f2 
Properly generate typedef identities in unions

Fixes #10605.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13201)
<!-- Reviewable:end -->
@highfive highfive removed the S-tests-failed label Sep 9, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2016

💔 Test failed - mac-rel-wpt
@highfive
Copy link

highfive commented Sep 9, 2016 

  ▶ ERROR [expected OK] /webgl/conformance-1.0.3/conformance/ogles/GL/build/build_009_to_016.html
  └   → gl.getProgramInfoLog is not a function
@jdm
Copy link
Member

jdm commented Sep 9, 2016

@bors-servo: retry
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Sep 9, 2016

@bors-servo retry

  • infra
@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2016

⌛ Testing commit 3976d97 with merge 1b3c7ed...
bors-servo added a commit that referenced this pull request Sep 9, 2016
@bors-servo
Auto merge of #13201 - KiChjang:codegen-typedefs, r=nox
Loading status checks…
1b3c7ed 
Properly generate typedef identities in unions

Fixes #10605.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13201)
<!-- Reviewable:end -->
@KiChjang KiChjang mentioned this pull request Sep 10, 2016
Closed
@bors-servo
Copy link
Contributor

bors-servo commented Sep 10, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit 3976d97 into servo:master Sep 10, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@KiChjang KiChjang deleted the KiChjang:codegen-typedefs branch Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@KiChjang @highfive @nox @bors-servo @jdm @larsbergstrom @Manishearth
You can’t perform that action at this time.