Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle None_ => None enum changes #13212

Merged
merged 1 commit into from Sep 10, 2016
Merged

Handle None_ => None enum changes #13212

merged 1 commit into from Sep 10, 2016

Conversation

@Manishearth
Copy link
Member

Manishearth commented Sep 9, 2016

Pulls in changes from https://bugzilla.mozilla.org/show_bug.cgi?id=1300337

r? @SimonSapin

don't mark for landing, I'll manually r= this when I do the next sync


This change is Reviewable

@highfive
Copy link

highfive commented Sep 9, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/gecko.mako.rs, components/style/properties/data.py
@highfive
Copy link

highfive commented Sep 9, 2016

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member

emilio commented Sep 9, 2016

r=me when it's ready

@Manishearth
Copy link
Member Author

Manishearth commented Sep 10, 2016

@bors-servo r=emilio

@bors-servo
Copy link
Contributor

bors-servo commented Sep 10, 2016

📌 Commit 3fe13a2 has been approved by emilio

@highfive highfive assigned emilio and unassigned SimonSapin Sep 10, 2016
bors-servo added a commit that referenced this pull request Sep 10, 2016
Handle None_ => None enum changes

Pulls in changes from https://bugzilla.mozilla.org/show_bug.cgi?id=1300337

r? @SimonSapin

don't mark for landing, I'll manually r= this when I do the next sync

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13212)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 10, 2016

Testing commit 3fe13a2 with merge f95c021...

@bors-servo
Copy link
Contributor

bors-servo commented Sep 10, 2016

💔 Test failed - mac-rel-wpt

@KiChjang
Copy link
Member

KiChjang commented Sep 10, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Sep 10, 2016

Testing commit 3fe13a2 with merge 5e7d918...

bors-servo added a commit that referenced this pull request Sep 10, 2016
Handle None_ => None enum changes

Pulls in changes from https://bugzilla.mozilla.org/show_bug.cgi?id=1300337

r? @SimonSapin

don't mark for landing, I'll manually r= this when I do the next sync

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13212)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 10, 2016

@bors-servo bors-servo merged commit 3fe13a2 into servo:master Sep 10, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.