Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mach Bootstrap: Support for more platforms #13226

Closed
wants to merge 7 commits into from
Closed

Conversation

@UK992
Copy link
Contributor

UK992 commented Sep 11, 2016

Adds support for Debian, Fedora and OS X.
On osx you need to choose package manager (Homebrew or MacPorts). Chosen manager will be set as default manager and written in .servo/default_package_manager file. If only one package manager exist, will be automatically chosen as default.

Also add new flag --silent and checks for missing packages before every build on all supported platforms.

If pip or virtualenv missing, it will run script to install packages needed for creating virtualenv.

Still need some testings if it works as expected, especially osx which i could only tested via travis-ci and at half-working virtual machine.


This change is Reviewable

@highfive
Copy link

highfive commented Sep 11, 2016

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/servo/bootstrapper/packages.py, python/servo/bootstrapper/bootstrap.py, python/servo/command_base.py, python/servo/bootstrapper/windows_gnu.py, python/servo/bootstrapper/debian.py, python/servo/bootstrapper/osx.py, python/servo/bootstrapper/centosfedora.py, python/servo/bootstrapper/windows_msvc.py, python/servo/bootstrapper/base.py, python/mach_bootstrap.py, python/servo/bootstrap_commands.py
@UK992 UK992 force-pushed the UK992:mach-bootstrap branch from 4e54ad8 to f256eae Sep 11, 2016
@UK992 UK992 force-pushed the UK992:mach-bootstrap branch from f256eae to fa97cb4 Sep 11, 2016
@UK992 UK992 force-pushed the UK992:mach-bootstrap branch from fa97cb4 to e3cac2f Sep 11, 2016
@UK992 UK992 changed the title mach bootstrap: Add support for more platform Mach Bootstrap: Support for more platforms Sep 12, 2016
@aneeshusa
Copy link
Member

aneeshusa commented Sep 12, 2016

I think we can re-use/migrate our Salt configurations from saltfs here instead of re-creating the package maangement logic, which I would prefer to do. I will check into the feasibility of this and leave another comment.

@UK992
Copy link
Contributor Author

UK992 commented Sep 22, 2016

@aneeshusa Any informations about feasibility of Salt configuration?

@aneeshusa
Copy link
Member

aneeshusa commented Sep 22, 2016

@UK992 It looks like Salt can be run from inside a virtualenv, so I'm working on a PR that sets that up.

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Sep 22, 2016

This is SUPER exciting to me because it means that user machines and CI machines are provisioned in exactly the same manner. Thank you both for working on it!

@jdm jdm assigned aneeshusa and unassigned nox Sep 22, 2016
@aneeshusa
Copy link
Member

aneeshusa commented Sep 27, 2016

FYI, this is on hold until servo/saltfs#483 is merged + deployed + the kinks are worked out, since it jumps our Salt version by two major versions (to the latest).

@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2016

The latest upstream changes (presumably #13382) made this pull request unmergeable. Please resolve the merge conflicts.

@wafflespeanut
Copy link
Member

wafflespeanut commented Dec 28, 2016

Ping @aneeshusa

@aneeshusa
Copy link
Member

aneeshusa commented Jan 12, 2017

Watch #14974 for updates.

@aneeshusa
Copy link
Member

aneeshusa commented Jan 20, 2017

Closing since #14974 is merged, however @UK992 I'd love to see the Fedora/Debian support added to the Salt-based mach bootstrap by upstreaming those package lists to the saltfs repo!

@aneeshusa aneeshusa closed this Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.