Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMach Bootstrap: Support for more platforms #13226
Conversation
highfive
commented
Sep 11, 2016
|
Heads up! This PR modifies the following files:
|
|
I think we can re-use/migrate our Salt configurations from saltfs here instead of re-creating the package maangement logic, which I would prefer to do. I will check into the feasibility of this and leave another comment. |
|
@aneeshusa Any informations about feasibility of Salt configuration? |
|
@UK992 It looks like Salt can be run from inside a virtualenv, so I'm working on a PR that sets that up. |
|
This is SUPER exciting to me because it means that user machines and CI machines are provisioned in exactly the same manner. Thank you both for working on it! |
|
FYI, this is on hold until servo/saltfs#483 is merged + deployed + the kinks are worked out, since it jumps our Salt version by two major versions (to the latest). |
|
|
|
Ping @aneeshusa |
|
Watch #14974 for updates. |
UK992 commentedSep 11, 2016
•
edited
Adds support for Debian, Fedora and OS X.
On osx you need to choose package manager (Homebrew or MacPorts). Chosen manager will be set as default manager and written in
.servo/default_package_managerfile. If only one package manager exist, will be automatically chosen as default.Also add new flag
--silentand checks for missing packages before every build on all supported platforms.If pip or virtualenv missing, it will run script to install packages needed for creating virtualenv.
Still need some testings if it works as expected, especially osx which i could only tested via travis-ci and at half-working virtual machine.
This change is