Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize rotations in computed transforms #13275

Merged
merged 1 commit into from Sep 15, 2016
Merged

Normalize rotations in computed transforms #13275

merged 1 commit into from Sep 15, 2016
+69 −1

Conversation

@canova
Copy link
Member

canova commented Sep 15, 2016 •
edited

Normalize rotations in computed transforms.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #13265 (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@highfive
Copy link

highfive commented Sep 15, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/effects.mako.rs
@highfive
Copy link

highfive commented Sep 15, 2016

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@Manishearth
Copy link
Member

Manishearth commented Sep 15, 2016

@bors-servo try
bors-servo added a commit that referenced this pull request Sep 15, 2016
@bors-servo
Auto merge of #13275 - canaltinova:rotate, r=<try>
Loading status checks…
c13e259 
Normalize rotations in computed transforms

<!-- Please describe your changes on the following line: -->
Normalize rotations in computed transforms.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13265  (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2016

⌛ Trying commit 8f5da31 with merge c13e259...
@Manishearth
Copy link
Member

Manishearth commented Sep 15, 2016

r=me on changes, if tests pass.

Once we know the tests pass we'd need to add a new test if it's not tested already.
@Manishearth
Copy link
Member

Manishearth commented Sep 15, 2016

@bors-servo delegate+

Use this to trigger try yourself, but please don't r+ until your own test is added
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2016

✌️ @canaltinova can now approve this pull request
@canova
Copy link
Member Author

canova commented Sep 15, 2016

@Manishearth Ok, thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2016

💔 Test failed - mac-rel-wpt
@Manishearth
Copy link
Member

Manishearth commented Sep 15, 2016

Looks like the CSS tests passed, that's just an intermittent. http://build.servo.org/builders/mac-rel-css/builds/3003

Could you add a new test to mozilla/ that ensures that rotate3d(1,1,1,45deg) is the same as rotate3d(0.5,0.5,0.5,45deg)?
@canova
Copy link
Member Author

canova commented Sep 15, 2016

@bors-servo try
@canova canova force-pushed the canova:rotate branch from 8f5da31 to 0d0716b Sep 15, 2016
@canova
Normalize rotations in computed transforms
Loading status checks…
20b3c4b
@canova canova force-pushed the canova:rotate branch from 0d0716b to 20b3c4b Sep 15, 2016
@canova
Copy link
Member Author

canova commented Sep 15, 2016

Added a test. Could you r? @Manishearth
@highfive highfive assigned Manishearth and unassigned glennw Sep 15, 2016
@Manishearth
Copy link
Member

Manishearth commented Sep 15, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2016

📌 Commit 20b3c4b has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2016

⌛ Testing commit 20b3c4b with merge 2024487...
bors-servo added a commit that referenced this pull request Sep 15, 2016
@bors-servo
Auto merge of #13275 - canaltinova:rotate, r=Manishearth
Loading status checks…
2024487 
Normalize rotations in computed transforms

<!-- Please describe your changes on the following line: -->
Normalize rotations in computed transforms.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13265  (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13275)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit 20b3c4b into servo:master Sep 15, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@canova canova deleted the canova:rotate branch Sep 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Normalize rotations in computed transforms
5 participants
@canova @highfive @Manishearth @bors-servo @glennw
You can’t perform that action at this time.