Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DOMTokenList Iterable #13280

Merged
merged 1 commit into from Sep 16, 2016
Merged

Make DOMTokenList Iterable #13280

merged 1 commit into from Sep 16, 2016

Conversation

@tizianasellitto
Copy link
Contributor

tizianasellitto commented Sep 15, 2016 •
edited by larsbergstrom

Make DOMTokenList Iterable.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #13019
  • There are tests for these changes (It adds tests/wpt/web-platform-tests/dom/lists/DOMTokenList-Iterable.html)

This change is Reviewable
@tizianasellitto
Make DOMTokenList Iterable
Loading status checks…
4efaa91
@highfive
Copy link

highfive commented Sep 15, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon.
@highfive
Copy link

highfive commented Sep 15, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/webidls/DOMTokenList.webidl
@jdm
Copy link
Member

jdm commented Sep 15, 2016

@bors-servo: r+
This looks great; thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2016

📌 Commit 4efaa91 has been approved by jdm
@highfive highfive assigned jdm and unassigned metajack Sep 15, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2016

⌛ Testing commit 4efaa91 with merge 9fc472e...
bors-servo added a commit that referenced this pull request Sep 15, 2016
@bors-servo
Auto merge of #13280 - tizianasellitto:issue_13019, r=jdm
Loading status checks…
9fc472e 
Make DOMTokenList Iterable

Make DOMTokenList Iterable.

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13019
- [X] There are tests for these changes (It adds tests/wpt/web-platform-tests/dom/lists/DOMTokenList-Iterable.html)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13280)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Sep 15, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-table-007.htm
  └   → /css-transforms-1_dev/html/transform-table-007.htm a5c014b20ef1363bea6f24eda28c7efb7c45698a
/css-transforms-1_dev/html/reference/transform-blank-ref.htm fa6407b1acbbfea27e27061e7d1bdeca98e4a728
Testing a5c014b20ef1363bea6f24eda28c7efb7c45698a == fa6407b1acbbfea27e27061e7d1bdeca98e4a728
@jdm
Copy link
Member

jdm commented Sep 15, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2016

⌛ Testing commit 4efaa91 with merge e3d946b...
bors-servo added a commit that referenced this pull request Sep 15, 2016
@bors-servo
Auto merge of #13280 - tizianasellitto:issue_13019, r=jdm
Loading status checks…
e3d946b 
Make DOMTokenList Iterable

Make DOMTokenList Iterable.

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13019
- [X] There are tests for these changes (It adds tests/wpt/web-platform-tests/dom/lists/DOMTokenList-Iterable.html)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13280)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 16, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit 4efaa91 into servo:master Sep 16, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Sep 16, 2016
Merged
4 of 5 tasks complete
@tizianasellitto tizianasellitto deleted the tizianasellitto:issue_13019 branch Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Make DOMTokenList iterable
5 participants
@tizianasellitto @highfive @jdm @bors-servo @metajack
You can’t perform that action at this time.