Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update basic auth cache to key off of origin instead of url #13281

Merged
merged 4 commits into from Sep 16, 2016
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

store basic auth in cache on redirect response

  • Loading branch information
gilbertw1 committed Sep 16, 2016
commit 0bcd04d2abd338d4d8abb5539f66d1c44bab1569
@@ -1017,7 +1017,8 @@ pub fn load<A, B>(load_data: &LoadData,
new_auth_header = None;

if let Some(auth_header) = request_headers.get::<Authorization<Basic>>() {
if response.status().class() == StatusClass::Success {
if response.status().class() == StatusClass::Success ||
response.status().class() == StatusClass::Redirection {
let auth_entry = AuthCacheEntry {
user_name: auth_header.username.to_owned(),
password: auth_header.password.to_owned().unwrap(),
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.