Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix most typoes for: "referer" -> "referrer" #13294

Merged
merged 1 commit into from Sep 16, 2016

Conversation

@6112
Copy link
Contributor

6112 commented Sep 16, 2016

Replace most uses of the word "referer" with "referrer", except for hyper::header::Referer. Also update the unit tests to compile & pass after those changes.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #13286
  • There are tests for these changes OR
  • These changes do not require tests because they're only typo fixes.

This change is Reviewable

@highfive
Copy link

highfive commented Sep 16, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/request.rs, components/net/fetch/methods.rs, components/net/http_loader.rs, components/script/dom/xmlhttprequest.rs, components/net_traits/request.rs, components/net_traits/request.rs
@jdm
Copy link
Member

jdm commented Sep 16, 2016

@bors-servo: r+
Thanks!

@bors-servo
Copy link
Contributor

bors-servo commented Sep 16, 2016

📌 Commit 924136e has been approved by jdm

@highfive highfive assigned jdm and unassigned metajack Sep 16, 2016
bors-servo added a commit that referenced this pull request Sep 16, 2016
Fix most typoes for: "referer" -> "referrer"

Replace most uses of the word "referer" with "referrer", except for `hyper::header::Referer`. Also update the unit tests to compile & pass after those changes.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13286

<!-- Either: -->
- [ ]  There are tests for these changes OR
- [X] These changes do not require tests because they're only typo fixes.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13294)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 16, 2016

Testing commit 924136e with merge 95940e6...

@bors-servo
Copy link
Contributor

bors-servo commented Sep 16, 2016

💔 Test failed - mac-rel-wpt

@jdm
Copy link
Member

jdm commented Sep 16, 2016

@bors-sevo: retry

@KiChjang
Copy link
Member

KiChjang commented Sep 16, 2016

bors-servo added a commit that referenced this pull request Sep 16, 2016
Fix most typoes for: "referer" -> "referrer"

Replace most uses of the word "referer" with "referrer", except for `hyper::header::Referer`. Also update the unit tests to compile & pass after those changes.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13286

<!-- Either: -->
- [ ]  There are tests for these changes OR
- [X] These changes do not require tests because they're only typo fixes.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13294)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 16, 2016

Testing commit 924136e with merge 8ccfffa...

@bors-servo
Copy link
Contributor

bors-servo commented Sep 16, 2016

@bors-servo bors-servo merged commit 924136e into servo:master Sep 16, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants
You can’t perform that action at this time.