Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require `PathBuf` ownership if we don't need it. #13304

Merged
merged 1 commit into from Sep 17, 2016
Merged

Don't require `PathBuf` ownership if we don't need it. #13304

merged 1 commit into from Sep 17, 2016

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Sep 17, 2016 •
edited by larsbergstrom

This change is Reviewable
@frewsxcv
Don't require `PathBuf` ownership if we don't need it.
Loading status checks…
3aa2ec6
@highfive
Copy link

highfive commented Sep 17, 2016

Heads up! This PR modifies the following files:
@highfive
Copy link

highfive commented Sep 17, 2016

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Sep 17, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2016

📌 Commit 3aa2ec6 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2016

⌛ Testing commit 3aa2ec6 with merge 6ac9dfd...
bors-servo added a commit that referenced this pull request Sep 17, 2016
@bors-servo
Auto merge of #13304 - frewsxcv:ownership, r=jdm
Loading status checks…
6ac9dfd 
Don't require `PathBuf` ownership if we don't need it.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13304)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2016

💔 Test failed - mac-rel-wpt
@KiChjang
Copy link
Member

KiChjang commented Sep 17, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit 3aa2ec6 into servo:master Sep 17, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@frewsxcv frewsxcv deleted the frewsxcv:ownership branch Oct 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@frewsxcv @highfive @jdm @bors-servo @KiChjang
You can’t perform that action at this time.