Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDecode UTF-8 with from_utf8_lossy in DedicatedWorkerGlobalScope #13306
Conversation
highfive
commented
Sep 18, 2016
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @larsbergstrom (or someone else) soon. |
highfive
commented
Sep 18, 2016
|
Heads up! This PR modifies the following files:
|
|
Thanks! Just two small comments. |
| @@ -173,7 +173,7 @@ impl DedicatedWorkerGlobalScope { | |||
|
|
|||
| let roots = RootCollection::new(); | |||
| let _stack_roots_tls = StackRootTLS::new(&roots); | |||
| let (url, source) = match load_whole_resource(LoadContext::Script, | |||
| let (metadata, bytes) = match load_whole_resource(LoadContext::Script, | |||
This comment has been minimized.
This comment has been minimized.
Ms2ger
Sep 19, 2016
Contributor
Nit: realign the other arguments to load_whole_resource so they line up again.
| @@ -1,4 +1,4 @@ | |||
| [004.worker] | |||
| type: testharness | |||
| bug: https://github.com/servo/servo/issues/13247 | |||
| expected: CRASH | |||
| expected: PASS | |||
This comment has been minimized.
This comment has been minimized.
|
@Ms2ger Just updated the PR to fix you comments. |
|
Thanks so much! @bors-servo r+ |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 19, 2016
…Ms2ger Decode UTF-8 with from_utf8_lossy in DedicatedWorkerGlobalScope <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #13247 <!-- Either: --> - [X] There are tests for these changes: `./mach test-wpt /workers/semantics/encodings/004.worker` passes <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13306) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Jenselme commentedSep 18, 2016
•
edited by larsbergstrom
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors./mach test-wpt /workers/semantics/encodings/004.workerpassesThis change is