Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFlush style sharing cache on parent mismatch. #13312
Merged
Conversation
highfive
commented
Sep 19, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Sep 19, 2016
|
|
|
@bors-servo: try |
bors-servo
added a commit
that referenced
this pull request
Sep 19, 2016
Flush style sharing cache on parent mismatch. Fixes #12913. No new tests were added, but we should at least make sure existing tests still pass. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12913 <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13312) <!-- Reviewable:end -->
|
|
|
Well, this is embarassing. @emilio, any idea what might be causing the test to time out? I suppose we somehow get stuck in an infinite loop... |
|
@bors-servo: retry
|
|
@bors-servo: try |
|
@bors-servo: retry |
bors-servo
added a commit
that referenced
this pull request
Sep 20, 2016
Flush style sharing cache on parent mismatch. Fixes #12913. No new tests were added, but we should at least make sure existing tests still pass. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12913 <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13312) <!-- Reviewable:end -->
|
|
|
Yeah, this looks great, thanks for the PR! @bors-servo: r+ |
|
|
|
@bors-servo: r- try- clean |
|
@bors-servo: r+ |
|
|
|
@bors-servo: try- r- clean |
|
@bors-servo: r+ |
|
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 23, 2016
Flush style sharing cache on parent mismatch. Fixes #12913. No new tests were added, but we should at least make sure existing tests still pass. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12913 <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13312) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
bors-servo
added a commit
that referenced
this pull request
Sep 23, 2016
Flush style sharing cache on parent mismatch. Fixes #12913. No new tests were added, but we should at least make sure existing tests still pass. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12913 <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13312) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
6112 commentedSep 19, 2016
•
edited by larsbergstrom
Fixes #12913. No new tests were added, but we should at least make sure existing tests still pass.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is