Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate string_cache to 0.2.29 #13314
Merged
Conversation
highfive
commented
Sep 19, 2016
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @asajeffrey (or someone else) soon. |
|
@bors-servo r+ Thanks! |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 19, 2016
…jang Update string_cache to 0.2.29 <!-- Please describe your changes on the following line: --> Update string-cache from 0.2.28 to 0.2.29 which includes `minlength` for #13313. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors <!-- Either: --> - [X] These changes do not require tests because this is only adding a single string to string-cache (ref servo/string-cache#172) <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13314) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 20, 2016
…rewster Implement minlength attribute for text inputs <!-- Please describe your changes on the following line: --> **This is not ready to be merged: I need help writing tests as I am not familiar with the methods used in the `maxlength` tests (introduced in tests/unit/script/textinput.rs).** I also need to write the `minlength-manual` test. Closes #13313 This depends on #13314 (and includes the commit from it so will need to be rebased once that patch lands). I am just looking for a quick review to make sure I am on the right path. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #13313 <!-- Either: --> - [X] There ~~are~~ *will be* tests for these changes <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13315) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this pull request
Sep 21, 2016
…rewster Implement minlength attribute for text inputs <!-- Please describe your changes on the following line: --> **This is not ready to be merged: I need help writing tests as I am not familiar with the methods used in the `maxlength` tests (introduced in tests/unit/script/textinput.rs).** I also need to write the `minlength-manual` test. Closes #13313 This depends on #13314 (and includes the commit from it so will need to be rebased once that patch lands). I am just looking for a quick review to make sure I am on the right path. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #13313 <!-- Either: --> - [X] There ~~are~~ *will be* tests for these changes <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13315) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this pull request
Sep 21, 2016
…rewster Implement minlength attribute for text inputs <!-- Please describe your changes on the following line: --> **This is not ready to be merged: I need help writing tests as I am not familiar with the methods used in the `maxlength` tests (introduced in tests/unit/script/textinput.rs).** I also need to write the `minlength-manual` test. Closes #13313 This depends on #13314 (and includes the commit from it so will need to be rebased once that patch lands). I am just looking for a quick review to make sure I am on the right path. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #13313 <!-- Either: --> - [X] There ~~are~~ *will be* tests for these changes <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13315) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Phrohdoh commentedSep 19, 2016
•
edited by larsbergstrom
Update string-cache from 0.2.28 to 0.2.29 which includes
minlengthfor #13313../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is