Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement minlength attribute for text inputs #13315
This is not ready to be merged:
I also need to write the
I am just looking for a quick review to make sure I am on the right path.
Heads up! This PR modifies the following files:
Thanks for doing this!
Overall this looks good to me, just one question.
Indeed tests are desired, but
Regarding enforcing minlength @jdm and I spoke about that on IRC today and I believe the consensus was to only enforce this on form validation.
If you have a greater-than-zero
Is form validation not built into Servo at all at this point?
added a commit
this pull request
Sep 20, 2016
Looks like some test expectations will need updated
Well.. that is an odd failure.
Looks like I need to update the proto.