Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update offscreen_gl_context dependency to get webgl fix. #13324

Merged
merged 1 commit into from Sep 19, 2016
Merged

Update offscreen_gl_context dependency to get webgl fix. #13324

merged 1 commit into from Sep 19, 2016

Conversation

@anholt
Copy link
Contributor

anholt commented Sep 19, 2016 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #11618
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@anholt
Update offscreen_gl_context dependency to get webgl fix.
Loading status checks…
0303767 
Fixes #11618 (intermittent failure in default_texture.html) by not
polluting our context's binding with the texture it created.
@anholt anholt force-pushed the anholt:webgl-default-texture branch from 1ae7329 to 0303767 Sep 19, 2016
@jdm
Copy link
Member

jdm commented Sep 19, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 19, 2016

📌 Commit 0303767 has been approved by jdm
@highfive highfive assigned jdm and unassigned nox Sep 19, 2016
@anholt
Copy link
Contributor Author

anholt commented Sep 19, 2016

Appveyor fail doesn't look related?
@bors-servo
Copy link
Contributor

bors-servo commented Sep 19, 2016

⌛ Testing commit 0303767 with merge dc3e11f...
bors-servo added a commit that referenced this pull request Sep 19, 2016
@bors-servo
Auto merge of #13324 - anholt:webgl-default-texture, r=jdm
Loading status checks…
dc3e11f 
Update offscreen_gl_context dependency to get webgl fix.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11618

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13324)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 19, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit 0303767 into servo:master Sep 19, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Intermittent failure in /webgl/conformance-1.0.3/conformance/textures/default-texture.html
5 participants
@anholt @jdm @bors-servo @nox @highfive
You can’t perform that action at this time.