New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout: Make `baseline_offset_of_last_line_box_in_flow()` only check blocks in flow. #13329

Merged
merged 1 commit into from Sep 20, 2016

Conversation

Projects
None yet
4 participants
@pcwalton
Contributor

pcwalton commented Sep 20, 2016

Improves python.org.

Closes #12124.

r? @notriddle


This change is Reviewable

layout: Make `baseline_offset_of_last_line_box_in_flow()` only check
blocks in flow.

Improves python.org.

Closes #12124.
@notriddle

This comment has been minimized.

Show comment
Hide comment
Contributor

notriddle commented Sep 20, 2016

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 20, 2016

Contributor

📌 Commit c6b9b31 has been approved by notriddle

Contributor

bors-servo commented Sep 20, 2016

📌 Commit c6b9b31 has been approved by notriddle

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 20, 2016

Contributor

⌛️ Testing commit c6b9b31 with merge d8d4598...

Contributor

bors-servo commented Sep 20, 2016

⌛️ Testing commit c6b9b31 with merge d8d4598...

bors-servo added a commit that referenced this pull request Sep 20, 2016

Auto merge of #13329 - pcwalton:last-line-in-flow, r=notriddle
layout: Make `baseline_offset_of_last_line_box_in_flow()` only check blocks in flow.

Improves python.org.

Closes #12124.

r? @notriddle

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13329)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 20, 2016

Contributor

💔 Test failed - mac-rel-wpt

Contributor

bors-servo commented Sep 20, 2016

💔 Test failed - mac-rel-wpt

@notriddle

This comment has been minimized.

Show comment
Hide comment
Contributor

notriddle commented Sep 20, 2016

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 20, 2016

Contributor

⌛️ Testing commit c6b9b31 with merge 53938c4...

Contributor

bors-servo commented Sep 20, 2016

⌛️ Testing commit c6b9b31 with merge 53938c4...

bors-servo added a commit that referenced this pull request Sep 20, 2016

Auto merge of #13329 - pcwalton:last-line-in-flow, r=notriddle
layout: Make `baseline_offset_of_last_line_box_in_flow()` only check blocks in flow.

Improves python.org.

Closes #12124.

r? @notriddle

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13329)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
Contributor

bors-servo commented Sep 20, 2016

@bors-servo bors-servo merged commit c6b9b31 into servo:master Sep 20, 2016

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@pcwalton pcwalton deleted the pcwalton:last-line-in-flow branch Sep 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment