Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix JS IndexedGetter and NamedSetter bindings generation #13333
Merged
Conversation
highfive
commented
Sep 20, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Sep 20, 2016
|
|
|
The related issue is #5876 |
| "}\n") % (self.descriptor.name, self.descriptor.name) | ||
| " if result.is_some() {\n" | ||
| " return (*opresult).failNoNamedSetter();\n" | ||
| " }\n" |
This comment has been minimized.
This comment has been minimized.
Ms2ger
Sep 20, 2016
Contributor
You seem to have removed a return in the not-found case; is that intentional?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 22, 2016
fix JS IndexedGetter and NamedSetter bindings generation <!-- Please describe your changes on the following line: --> Fix JS IndexedGetter and NamedSetter bindings generation. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #13327 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because the test will be in PR for #13129 as currently these setters are used by nobody. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13333) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
splav commentedSep 20, 2016
•
edited by jdm
Fix JS IndexedGetter and NamedSetter bindings generation.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is