Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style input-text pseudo with user-agent CSS #13354

Merged
merged 1 commit into from Sep 24, 2016
Merged

Style input-text pseudo with user-agent CSS #13354

merged 1 commit into from Sep 24, 2016

Conversation

schuster
Copy link
Contributor

@schuster schuster commented Sep 21, 2016 •
edited by larsbergstrom

This changes the input-text pseudo-element to be styled with user-agent CSS rather than having a hard-coded style, as part of #8570

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because they're a refactoring of existing functionality

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/servo_selector_impl.rs, components/style/properties/properties.mako.rs

@highfive
Copy link

warning Warning warning

  • These commits modify style and layout code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 21, 2016
@jdm
Copy link
Member

jdm commented Sep 21, 2016

r? @pcwalton

@highfive highfive assigned pcwalton and unassigned jdm Sep 21, 2016
@pcwalton
Copy link
Contributor

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit bf7df32 has been approved by pcwalton

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 21, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit bf7df32 with merge 4f356de...

bors-servo pushed a commit that referenced this pull request Sep 21, 2016
Auto merge of #13354 - schuster:input-text-style, r=pcwalton
4f356de 
Style input-text pseudo with user-agent CSS

This changes the input-text pseudo-element to be styled with user-agent CSS rather than having a hard-coded style, as part of #8570

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they're a refactoring of existing functionality

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13354)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-css

@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Sep 21, 2016
@highfive
Copy link 

  ▶ PASS [expected FAIL] /css-flexbox-1_dev/html/flex-vertical-align-effect.htm

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Sep 21, 2016
@jdm
Copy link
Member

jdm commented Sep 21, 2016

@bors-servo: try

@jdm
Copy link
Member

jdm commented Sep 21, 2016

Oh, that test result change is actually totally plausible - the test in question uses <input>, and it's likely that the function that was removed wasn't being called from the flexbox layout code.

@schuster
Copy link
Contributor Author

@jdm I agree, seems plausible. I'll look into it.

What about the apparent build failure on AppVeyor? It seems to not be finding mach, and I have a hard time imagining my change affected that.

@jdm
Copy link
Member

jdm commented Sep 21, 2016

That's #13340.

@stshine
Copy link
Contributor

stshine commented Sep 21, 2016

There are text in the input in the passed test, and it looks like that they are now properly aligned to the middle while they are previously aligned to the top in the reference test. Looks like the input text inproperly inherited the non-inherit property vertical-align from input with the modify_style_for_* function.
The passed test seems to be OK.

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Sep 22, 2016
@schuster
Copy link
Contributor Author

@stshine I think you're right. I updated the expected test result and rebased the change in.

@schuster
Copy link
Contributor Author

Does this just need a retry? The build seems to be fine on both my Linux and OS X machines.

@jdm
Copy link
Member

jdm commented Sep 23, 2016

@bors-servo: r=pcwalton

@bors-servo
Copy link
Contributor

📌 Commit 8500f3c has been approved by pcwalton

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 23, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 8500f3c with merge 572fc15...

bors-servo pushed a commit that referenced this pull request Sep 23, 2016
Auto merge of #13354 - schuster:input-text-style, r=pcwalton
572fc15 
Style input-text pseudo with user-agent CSS

This changes the input-text pseudo-element to be styled with user-agent CSS rather than having a hard-coded style, as part of #8570

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they're a refactoring of existing functionality

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13354)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel

@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Sep 23, 2016
@highfive
Copy link 

  ▶ Unexpected subtest result in /_mozilla/mozilla/promise.html:
  │ FAIL [expected PASS] Native promise from async callback can be resolved
  │   → assert_true: expected true got false
  │ 
  └ @http://web-platform.test:8000/_mozilla/mozilla/promise.html:58:11

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Sep 23, 2016
@jdm
Copy link
Member

jdm commented Sep 23, 2016

@bors-servo: retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 8500f3c with merge 28ebab4...

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Sep 24, 2016
bors-servo pushed a commit that referenced this pull request Sep 24, 2016
Auto merge of #13354 - schuster:input-text-style, r=pcwalton
28ebab4 
Style input-text pseudo with user-agent CSS

This changes the input-text pseudo-element to be styled with user-agent CSS rather than having a hard-coded style, as part of #8570

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they're a refactoring of existing functionality

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13354)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev

@bors-servo bors-servo merged commit 8500f3c into servo:master Sep 24, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Sep 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcwalton pcwalton pcwalton approved these changes

Assignees

@pcwalton pcwalton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@schuster @highfive @jdm @pcwalton @bors-servo @stshine