Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style input-text pseudo with user-agent CSS #13354

Merged
merged 1 commit into from Sep 24, 2016
Merged

Style input-text pseudo with user-agent CSS #13354

merged 1 commit into from Sep 24, 2016

Conversation

@schuster
Copy link
Contributor

schuster commented Sep 21, 2016 •
edited by larsbergstrom

This changes the input-text pseudo-element to be styled with user-agent CSS rather than having a hard-coded style, as part of #8570

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because they're a refactoring of existing functionality

This change is Reviewable
@highfive
Copy link

highfive commented Sep 21, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/servo_selector_impl.rs, components/style/properties/properties.mako.rs
@highfive
Copy link

highfive commented Sep 21, 2016

warning Warning warning

  • These commits modify style and layout code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Sep 21, 2016

r? @pcwalton
@highfive highfive assigned pcwalton and unassigned jdm Sep 21, 2016
@pcwalton
pcwalton approved these changes Sep 21, 2016
View changes
@pcwalton
Copy link
Contributor

pcwalton commented Sep 21, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 21, 2016

📌 Commit bf7df32 has been approved by pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Sep 21, 2016

⌛ Testing commit bf7df32 with merge 4f356de...
bors-servo added a commit that referenced this pull request Sep 21, 2016
@bors-servo
Auto merge of #13354 - schuster:input-text-style, r=pcwalton
Loading status checks…
4f356de 
Style input-text pseudo with user-agent CSS

This changes the input-text pseudo-element to be styled with user-agent CSS rather than having a hard-coded style, as part of #8570

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they're a refactoring of existing functionality

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13354)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 21, 2016

💔 Test failed - mac-rel-css
@highfive
Copy link

highfive commented Sep 21, 2016 

  ▶ PASS [expected FAIL] /css-flexbox-1_dev/html/flex-vertical-align-effect.htm
@jdm
Copy link
Member

jdm commented Sep 21, 2016

@bors-servo: try
@jdm
Copy link
Member

jdm commented Sep 21, 2016

Oh, that test result change is actually totally plausible - the test in question uses <input>, and it's likely that the function that was removed wasn't being called from the flexbox layout code.
@schuster
Copy link
Contributor Author

schuster commented Sep 21, 2016

@jdm I agree, seems plausible. I'll look into it.

What about the apparent build failure on AppVeyor? It seems to not be finding mach, and I have a hard time imagining my change affected that.
@jdm
Copy link
Member

jdm commented Sep 21, 2016

That's #13340.
@stshine
Copy link
Contributor

stshine commented Sep 21, 2016

There are text in the input in the passed test, and it looks like that they are now properly aligned to the middle while they are previously aligned to the top in the reference test. Looks like the input text inproperly inherited the non-inherit property vertical-align from input with the modify_style_for_* function.
The passed test seems to be OK.
@schuster
Style input-text pseudo with user-agent CSS
Loading status checks…
8500f3c
@schuster schuster force-pushed the schuster:input-text-style branch from bf7df32 to 8500f3c Sep 22, 2016
@schuster
Copy link
Contributor Author

schuster commented Sep 22, 2016

@stshine I think you're right. I updated the expected test result and rebased the change in.
@schuster
Copy link
Contributor Author

schuster commented Sep 23, 2016

Does this just need a retry? The build seems to be fine on both my Linux and OS X machines.
@jdm
Copy link
Member

jdm commented Sep 23, 2016

@bors-servo: r=pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Sep 23, 2016

📌 Commit 8500f3c has been approved by pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Sep 23, 2016

⌛ Testing commit 8500f3c with merge 572fc15...
bors-servo added a commit that referenced this pull request Sep 23, 2016
@bors-servo
Auto merge of #13354 - schuster:input-text-style, r=pcwalton
Loading status checks…
572fc15 
Style input-text pseudo with user-agent CSS

This changes the input-text pseudo-element to be styled with user-agent CSS rather than having a hard-coded style, as part of #8570

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they're a refactoring of existing functionality

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13354)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 23, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Sep 23, 2016 

  ▶ Unexpected subtest result in /_mozilla/mozilla/promise.html:
  │ FAIL [expected PASS] Native promise from async callback can be resolved
  │   → assert_true: expected true got false
  │ 
  └ @http://web-platform.test:8000/_mozilla/mozilla/promise.html:58:11
@jdm
Copy link
Member

jdm commented Sep 23, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 24, 2016

⌛ Testing commit 8500f3c with merge 28ebab4...
bors-servo added a commit that referenced this pull request Sep 24, 2016
@bors-servo
Auto merge of #13354 - schuster:input-text-style, r=pcwalton
Loading status checks…
28ebab4 
Style input-text pseudo with user-agent CSS

This changes the input-text pseudo-element to be styled with user-agent CSS rather than having a hard-coded style, as part of #8570

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they're a refactoring of existing functionality

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13354)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 24, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit 8500f3c into servo:master Sep 24, 2016
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcwalton pcwalton

Assignees

@pcwalton pcwalton

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@schuster @highfive @jdm @pcwalton @bors-servo @stshine
You can’t perform that action at this time.