New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style input-text pseudo with user-agent CSS #13354

Merged
merged 1 commit into from Sep 24, 2016

Conversation

Projects
None yet
6 participants
@schuster
Contributor

schuster commented Sep 21, 2016

This changes the input-text pseudo-element to be styled with user-agent CSS rather than having a hard-coded style, as part of #8570


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because they're a refactoring of existing functionality

This change is Reviewable

@highfive

This comment has been minimized.

Show comment
Hide comment
@highfive

highfive Sep 21, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/servo_selector_impl.rs, components/style/properties/properties.mako.rs

Heads up! This PR modifies the following files:

  • @bholley: components/style/servo_selector_impl.rs, components/style/properties/properties.mako.rs
@highfive

This comment has been minimized.

Show comment
Hide comment
@highfive

highfive Sep 21, 2016

warning Warning warning

  • These commits modify style and layout code, but no tests are modified. Please consider adding a test!

warning Warning warning

  • These commits modify style and layout code, but no tests are modified. Please consider adding a test!
@jdm

This comment has been minimized.

Show comment
Hide comment
Member

jdm commented Sep 21, 2016

@highfive highfive assigned pcwalton and unassigned jdm Sep 21, 2016

@pcwalton

This comment has been minimized.

Show comment
Hide comment
Contributor

pcwalton commented Sep 21, 2016

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 21, 2016

Contributor

📌 Commit bf7df32 has been approved by pcwalton

Contributor

bors-servo commented Sep 21, 2016

📌 Commit bf7df32 has been approved by pcwalton

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 21, 2016

Contributor

⌛️ Testing commit bf7df32 with merge 4f356de...

Contributor

bors-servo commented Sep 21, 2016

⌛️ Testing commit bf7df32 with merge 4f356de...

bors-servo added a commit that referenced this pull request Sep 21, 2016

Auto merge of #13354 - schuster:input-text-style, r=pcwalton
Style input-text pseudo with user-agent CSS

This changes the input-text pseudo-element to be styled with user-agent CSS rather than having a hard-coded style, as part of #8570

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they're a refactoring of existing functionality

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13354)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 21, 2016

Contributor

💔 Test failed - mac-rel-css

Contributor

bors-servo commented Sep 21, 2016

💔 Test failed - mac-rel-css

@highfive

This comment has been minimized.

Show comment
Hide comment
@highfive

highfive Sep 21, 2016

  ▶ PASS [expected FAIL] /css-flexbox-1_dev/html/flex-vertical-align-effect.htm
  ▶ PASS [expected FAIL] /css-flexbox-1_dev/html/flex-vertical-align-effect.htm
@jdm

This comment has been minimized.

Show comment
Hide comment
Member

jdm commented Sep 21, 2016

@jdm

This comment has been minimized.

Show comment
Hide comment
@jdm

jdm Sep 21, 2016

Member

Oh, that test result change is actually totally plausible - the test in question uses <input>, and it's likely that the function that was removed wasn't being called from the flexbox layout code.

Member

jdm commented Sep 21, 2016

Oh, that test result change is actually totally plausible - the test in question uses <input>, and it's likely that the function that was removed wasn't being called from the flexbox layout code.

@schuster

This comment has been minimized.

Show comment
Hide comment
@schuster

schuster Sep 21, 2016

Contributor

@jdm I agree, seems plausible. I'll look into it.

What about the apparent build failure on AppVeyor? It seems to not be finding mach, and I have a hard time imagining my change affected that.

Contributor

schuster commented Sep 21, 2016

@jdm I agree, seems plausible. I'll look into it.

What about the apparent build failure on AppVeyor? It seems to not be finding mach, and I have a hard time imagining my change affected that.

@jdm

This comment has been minimized.

Show comment
Hide comment
@jdm

jdm Sep 21, 2016

Member

That's #13340.

Member

jdm commented Sep 21, 2016

That's #13340.

@stshine

This comment has been minimized.

Show comment
Hide comment
@stshine

stshine Sep 21, 2016

Contributor

There are text in the input in the passed test, and it looks like that they are now properly aligned to the middle while they are previously aligned to the top in the reference test. Looks like the input text inproperly inherited the non-inherit property vertical-align from input with the modify_style_for_* function.
The passed test seems to be OK.

Contributor

stshine commented Sep 21, 2016

There are text in the input in the passed test, and it looks like that they are now properly aligned to the middle while they are previously aligned to the top in the reference test. Looks like the input text inproperly inherited the non-inherit property vertical-align from input with the modify_style_for_* function.
The passed test seems to be OK.

@schuster

This comment has been minimized.

Show comment
Hide comment
@schuster

schuster Sep 22, 2016

Contributor

@stshine I think you're right. I updated the expected test result and rebased the change in.

Contributor

schuster commented Sep 22, 2016

@stshine I think you're right. I updated the expected test result and rebased the change in.

@schuster

This comment has been minimized.

Show comment
Hide comment
@schuster

schuster Sep 23, 2016

Contributor

Does this just need a retry? The build seems to be fine on both my Linux and OS X machines.

Contributor

schuster commented Sep 23, 2016

Does this just need a retry? The build seems to be fine on both my Linux and OS X machines.

@jdm

This comment has been minimized.

Show comment
Hide comment
@jdm

jdm Sep 23, 2016

Member

@bors-servo: r=pcwalton

Member

jdm commented Sep 23, 2016

@bors-servo: r=pcwalton

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 23, 2016

Contributor

📌 Commit 8500f3c has been approved by pcwalton

Contributor

bors-servo commented Sep 23, 2016

📌 Commit 8500f3c has been approved by pcwalton

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 23, 2016

Contributor

⌛️ Testing commit 8500f3c with merge 572fc15...

Contributor

bors-servo commented Sep 23, 2016

⌛️ Testing commit 8500f3c with merge 572fc15...

bors-servo added a commit that referenced this pull request Sep 23, 2016

Auto merge of #13354 - schuster:input-text-style, r=pcwalton
Style input-text pseudo with user-agent CSS

This changes the input-text pseudo-element to be styled with user-agent CSS rather than having a hard-coded style, as part of #8570

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they're a refactoring of existing functionality

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13354)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 23, 2016

Contributor

💔 Test failed - linux-rel

Contributor

bors-servo commented Sep 23, 2016

💔 Test failed - linux-rel

@highfive

This comment has been minimized.

Show comment
Hide comment
@highfive

highfive Sep 23, 2016

  ▶ Unexpected subtest result in /_mozilla/mozilla/promise.html:
  │ FAIL [expected PASS] Native promise from async callback can be resolved
  │   → assert_true: expected true got false
  │ 
  └ @http://web-platform.test:8000/_mozilla/mozilla/promise.html:58:11
  ▶ Unexpected subtest result in /_mozilla/mozilla/promise.html:
  │ FAIL [expected PASS] Native promise from async callback can be resolved
  │   → assert_true: expected true got false
  │ 
  └ @http://web-platform.test:8000/_mozilla/mozilla/promise.html:58:11
@jdm

This comment has been minimized.

Show comment
Hide comment
Member

jdm commented Sep 23, 2016

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 24, 2016

Contributor

⌛️ Testing commit 8500f3c with merge 28ebab4...

Contributor

bors-servo commented Sep 24, 2016

⌛️ Testing commit 8500f3c with merge 28ebab4...

bors-servo added a commit that referenced this pull request Sep 24, 2016

Auto merge of #13354 - schuster:input-text-style, r=pcwalton
Style input-text pseudo with user-agent CSS

This changes the input-text pseudo-element to be styled with user-agent CSS rather than having a hard-coded style, as part of #8570

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they're a refactoring of existing functionality

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13354)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
Contributor

bors-servo commented Sep 24, 2016

@bors-servo bors-servo merged commit 8500f3c into servo:master Sep 24, 2016

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment