Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appveyor and Travis fix #13383

Merged
merged 2 commits into from Sep 23, 2016
Merged

Appveyor and Travis fix #13383

merged 2 commits into from Sep 23, 2016

Conversation

@UK992
Copy link
Contributor

UK992 commented Sep 23, 2016 •
edited by larsbergstrom

Fixes #13340

This change is Reviewable
UK992 added 2 commits Sep 23, 2016
@UK992
Fix Appveyor
35b19d0
@UK992
Reorder steps in Travis to avoid rebuilding on `mach test-unit`
Loading status checks…
d695b97
@jdm
Copy link
Member

jdm commented Sep 23, 2016

@bors-servo: r+
Amazing! Thank you for solving this!
@bors-servo
Copy link
Contributor

bors-servo commented Sep 23, 2016

📌 Commit d695b97 has been approved by jdm
@highfive highfive assigned jdm and unassigned glennw Sep 23, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Sep 23, 2016

⌛ Testing commit d695b97 with merge ad62140...
bors-servo added a commit that referenced this pull request Sep 23, 2016
@bors-servo
Auto merge of #13383 - UK992:ci, r=jdm
Loading status checks…
ad62140 
Appveyor and Travis fix

Fixes #13340

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13383)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 23, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Sep 23, 2016 

  ▶ Unexpected subtest result in /_mozilla/mozilla/promise.html:
  │ FAIL [expected PASS] Native promise from async callback can be resolved
  │   → assert_true: expected true got false
  │ 
  └ @http://web-platform.test:8000/_mozilla/mozilla/promise.html:58:11
@jdm
Copy link
Member

jdm commented Sep 23, 2016

@bors-servo: retry
@jdm
Copy link
Member

jdm commented Sep 23, 2016

@bors-servo: p=1
@bors-servo
Copy link
Contributor

bors-servo commented Sep 23, 2016

⌛ Testing commit d695b97 with merge 4cb4e38...
bors-servo added a commit that referenced this pull request Sep 23, 2016
@bors-servo
Auto merge of #13383 - UK992:ci, r=jdm
Loading status checks…
4cb4e38 
Appveyor and Travis fix

Fixes #13340

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13383)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 23, 2016

💔 Test failed - mac-rel-wpt
@jdm
Copy link
Member

jdm commented Sep 23, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 23, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 23, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit d695b97 into servo:master Sep 23, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Sep 23, 2016
Merged
@UK992 UK992 deleted the UK992:ci branch Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@UK992 @jdm @bors-servo @highfive @glennw
You can’t perform that action at this time.