Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appveyor and Travis fix #13383

Merged
merged 2 commits into from Sep 23, 2016
Merged

Appveyor and Travis fix #13383

merged 2 commits into from Sep 23, 2016

Conversation

UK992
Copy link
Contributor

@UK992 UK992 commented Sep 23, 2016 •
edited by larsbergstrom

Fixes #13340

This change is Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 23, 2016
@jdm
Copy link
Member

jdm commented Sep 23, 2016

@bors-servo: r+
Amazing! Thank you for solving this!

@bors-servo
Copy link
Contributor

📌 Commit d695b97 has been approved by jdm

@highfive highfive assigned jdm and unassigned glennw Sep 23, 2016
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 23, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit d695b97 with merge ad62140...

bors-servo pushed a commit that referenced this pull request Sep 23, 2016
Auto merge of #13383 - UK992:ci, r=jdm
ad62140 
Appveyor and Travis fix

Fixes #13340

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13383)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Sep 23, 2016
@highfive
Copy link 

  ▶ Unexpected subtest result in /_mozilla/mozilla/promise.html:
  │ FAIL [expected PASS] Native promise from async callback can be resolved
  │   → assert_true: expected true got false
  │ 
  └ @http://web-platform.test:8000/_mozilla/mozilla/promise.html:58:11

@jdm
Copy link
Member

jdm commented Sep 23, 2016

@bors-servo: retry

@jdm
Copy link
Member

jdm commented Sep 23, 2016

@bors-servo: p=1

@bors-servo
Copy link
Contributor

⌛ Testing commit d695b97 with merge 4cb4e38...

bors-servo pushed a commit that referenced this pull request Sep 23, 2016
Auto merge of #13383 - UK992:ci, r=jdm
4cb4e38 
Appveyor and Travis fix

Fixes #13340

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13383)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Sep 23, 2016
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Sep 23, 2016
@jdm
Copy link
Member

jdm commented Sep 23, 2016

@bors-servo: retry

@bors-servo
Copy link
Contributor

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only mac-rel-wpt...

@bors-servo
Copy link
Contributor

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev

@bors-servo bors-servo merged commit d695b97 into servo:master Sep 23, 2016
@bors-servo bors-servo mentioned this pull request Sep 23, 2016
Merged
@UK992 UK992 deleted the ci branch January 26, 2017 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed The changes caused existing tests to fail.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@UK992 @jdm @bors-servo @highfive @glennw