Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAvoid a possible deadlock in main_fetch's synchronous code. #13388
Conversation
On playpen, similar code caused a deadlock on 1.11 stable, and worked fine on nightly 1.13; it seems safer to avoid the pattern entirely.
highfive
commented
Sep 23, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Sep 23, 2016
|
|
|
@bors-servo: r+ Yeah, I think the lifetime of the objects in if conditions was fixed not so long ago, so agreed. |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 24, 2016
Avoid a possible deadlock in main_fetch's synchronous code. On playpen, similar code caused a deadlock on 1.11 stable, and worked fine on nightly 1.13; it seems safer to avoid the pattern entirely. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13388) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ms2ger commentedSep 23, 2016
•
edited by larsbergstrom
On playpen, similar code caused a deadlock on 1.11 stable, and worked fine
on nightly 1.13; it seems safer to avoid the pattern entirely.
This change is