New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to use libc++ on OS X #13393

Merged
merged 1 commit into from Sep 23, 2016

Conversation

Projects
None yet
6 participants
@nox
Member

nox commented Sep 23, 2016

This change is Reviewable

@nox nox changed the title from Update dependencies to use libc++ on OS X to (Do not merge) Update dependencies to use libc++ on OS X Sep 23, 2016

@nox

This comment has been minimized.

Show comment
Hide comment
@nox
Member

nox commented Sep 23, 2016

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 23, 2016

Contributor

⌛️ Trying commit c9c115c with merge c2cd351...

Contributor

bors-servo commented Sep 23, 2016

⌛️ Trying commit c9c115c with merge c2cd351...

bors-servo added a commit that referenced this pull request Sep 23, 2016

Auto merge of #13393 - servo:libcxx, r=<try>
(Do not merge) Update dependencies to use libc++ on OS X
@nox

This comment has been minimized.

Show comment
Hide comment
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 23, 2016

Contributor

💔 Test failed - arm32

Contributor

bors-servo commented Sep 23, 2016

💔 Test failed - arm32

@nox

This comment has been minimized.

Show comment
Hide comment
@nox
Member

nox commented Sep 23, 2016

@highfive highfive assigned larsbergstrom and unassigned metajack Sep 23, 2016

@larsbergstrom

This comment has been minimized.

Show comment
Hide comment
@larsbergstrom

larsbergstrom Sep 23, 2016

Contributor

r=me with updated cargo.tomls & lockfiles once deps all land.

Contributor

larsbergstrom commented Sep 23, 2016

r=me with updated cargo.tomls & lockfiles once deps all land.

@nox

This comment has been minimized.

Show comment
Hide comment
@nox

nox Sep 23, 2016

Member

@bors-servo r=larsbergstrom

Member

nox commented Sep 23, 2016

@bors-servo r=larsbergstrom

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 23, 2016

Contributor

📌 Commit 1e176a2 has been approved by larsbergstrom

Contributor

bors-servo commented Sep 23, 2016

📌 Commit 1e176a2 has been approved by larsbergstrom

@nox nox changed the title from (Do not merge) Update dependencies to use libc++ on OS X to Update dependencies to use libc++ on OS X Sep 23, 2016

@nox

This comment has been minimized.

Show comment
Hide comment
@nox

nox Sep 23, 2016

Member

@bors-servo retry force clean

Let's not keep that "Do not merge" thing even in servo/servo.

Member

nox commented Sep 23, 2016

@bors-servo retry force clean

Let's not keep that "Do not merge" thing even in servo/servo.

@nox

This comment has been minimized.

Show comment
Hide comment
@nox

nox Sep 23, 2016

Member

@bors-servo p=1

Because people with Xcode 8 cannot build Servo at the moment.

Member

nox commented Sep 23, 2016

@bors-servo p=1

Because people with Xcode 8 cannot build Servo at the moment.

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 23, 2016

Contributor

⌛️ Testing commit 1e176a2 with merge d7c492e...

Contributor

bors-servo commented Sep 23, 2016

⌛️ Testing commit 1e176a2 with merge d7c492e...

bors-servo added a commit that referenced this pull request Sep 23, 2016

Auto merge of #13393 - servo:libcxx, r=larsbergstrom
Update dependencies to use libc++ on OS X

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13393)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 23, 2016

Contributor

💔 Test failed - mac-rel-wpt

Contributor

bors-servo commented Sep 23, 2016

💔 Test failed - mac-rel-wpt

@jdm

This comment has been minimized.

Show comment
Hide comment
@jdm
Member

jdm commented Sep 23, 2016

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 23, 2016

Contributor

⌛️ Testing commit 1e176a2 with merge 37e8e60...

Contributor

bors-servo commented Sep 23, 2016

⌛️ Testing commit 1e176a2 with merge 37e8e60...

bors-servo added a commit that referenced this pull request Sep 23, 2016

Auto merge of #13393 - servo:libcxx, r=larsbergstrom
Update dependencies to use libc++ on OS X

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13393)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 23, 2016

Contributor

💔 Test failed - mac-rel-wpt

Contributor

bors-servo commented Sep 23, 2016

💔 Test failed - mac-rel-wpt

@jdm

This comment has been minimized.

Show comment
Hide comment
@jdm
Member

jdm commented Sep 23, 2016

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 23, 2016

Contributor

⌛️ Testing commit 1e176a2 with merge 63b1d19...

Contributor

bors-servo commented Sep 23, 2016

⌛️ Testing commit 1e176a2 with merge 63b1d19...

bors-servo added a commit that referenced this pull request Sep 23, 2016

Auto merge of #13393 - servo:libcxx, r=larsbergstrom
Update dependencies to use libc++ on OS X

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13393)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo
Contributor

bors-servo commented Sep 23, 2016

@bors-servo bors-servo merged commit 1e176a2 into master Sep 23, 2016

2 of 4 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
dependency-ci Failed dependency checks
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@notriddle notriddle deleted the libcxx branch Sep 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment