New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FormData Iterable #13396

Merged
merged 1 commit into from Sep 24, 2016

Conversation

Projects
None yet
5 participants
@jdm
Member

jdm commented Sep 23, 2016

Implement FormData's iterator
Rebased from #13104.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #13020
  • There are tests for these changes (It adds ./mach test-wpt tests/wpt/web-platform-tests/XMLHttpRequest/formdata-foreach.html)

Notice: Our FormData is implemented by HashMap , which is different from Gecko's array implementation. So our FormData's iterator order is different from Gecko's, as there is no way to keep our key's original insertion order.


This change is Reviewable

@highfive

This comment has been minimized.

Show comment
Hide comment
@highfive

highfive Sep 23, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/webidls/FormData.webidl, components/script/dom/formdata.rs

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/webidls/FormData.webidl, components/script/dom/formdata.rs
@jdm

This comment has been minimized.

Show comment
Hide comment
Member

jdm commented Sep 23, 2016

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 23, 2016

Contributor

📌 Commit 652c578 has been approved by jdm

Contributor

bors-servo commented Sep 23, 2016

📌 Commit 652c578 has been approved by jdm

@highfive highfive assigned jdm and unassigned SimonSapin Sep 23, 2016

@jdm jdm referenced this pull request Sep 23, 2016

Closed

Added FormData Iterable #13104

4 of 4 tasks complete
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 24, 2016

Contributor

⌛️ Testing commit 652c578 with merge 89804bb...

Contributor

bors-servo commented Sep 24, 2016

⌛️ Testing commit 652c578 with merge 89804bb...

bors-servo added a commit that referenced this pull request Sep 24, 2016

Auto merge of #13396 - jdm:FormData_iterable, r=jdm
Added FormData Iterable

Implement FormData's iterator
Rebased from #13104.

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13020
- [X] There are tests for these changes (It adds `./mach test-wpt tests/wpt/web-platform-tests/XMLHttpRequest/formdata-foreach.html`)

Notice: Our `FormData` is implemented by `HashMap` ,  which is different from [Gecko's array implementation](https://github.com/mozilla/gecko-dev/blob/3c6ff93c8f92d822ab6a2ae42f55a9f837d62fe9/dom/base/FormData.h#L160). So our `FormData`'s iterator order is different from Gecko's, as there is no way to keep our key's original insertion order.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13396)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
Contributor

bors-servo commented Sep 24, 2016

@bors-servo bors-servo merged commit 652c578 into servo:master Sep 24, 2016

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment