New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: Manage servo node data directly from Servo #13404

Merged
merged 2 commits into from Sep 24, 2016

Conversation

Projects
None yet
5 participants
@bholley
Contributor

bholley commented Sep 24, 2016

Servo-side changes for: https://bugzilla.mozilla.org/show_bug.cgi?id=1304913


This change is Reviewable

@highfive

This comment has been minimized.

Show comment
Hide comment
@highfive

highfive Sep 24, 2016

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
Bug 1304913 - Have Servo manage node data directly without FFI calls.…
… r=Manishearth

MozReview-Commit-ID: H8f8VP18TbM
@bholley

This comment has been minimized.

Show comment
Hide comment
@bholley

bholley Sep 24, 2016

Contributor
Contributor

bholley commented Sep 24, 2016

bors-servo added a commit that referenced this pull request Sep 24, 2016

Auto merge of #13404 - bholley:manage_node_data, r=<try>
 stylo: Manage servo node data directly from Servo

Servo-side changes for: https://bugzilla.mozilla.org/show_bug.cgi?id=1304913

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13404)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 24, 2016

Contributor

⌛️ Trying commit ba743f5 with merge e8e3dac...

Contributor

bors-servo commented Sep 24, 2016

⌛️ Trying commit ba743f5 with merge e8e3dac...

@Manishearth

This comment has been minimized.

Show comment
Hide comment
@Manishearth

Manishearth Sep 24, 2016

Member

(you can r=me when you need it -- carrying over review from bugzilla is fine)

Member

Manishearth commented Sep 24, 2016

(you can r=me when you need it -- carrying over review from bugzilla is fine)

@bholley

This comment has been minimized.

Show comment
Hide comment
@bholley

bholley Sep 24, 2016

Contributor

@bors-servo r=Manishearth

Contributor

bholley commented Sep 24, 2016

@bors-servo r=Manishearth

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 24, 2016

Contributor

📌 Commit ba743f5 has been approved by Manishearth

Contributor

bors-servo commented Sep 24, 2016

📌 Commit ba743f5 has been approved by Manishearth

@Manishearth

This comment has been minimized.

Show comment
Hide comment
@Manishearth

Manishearth Sep 24, 2016

Member

@bors-servo try- r+ retry clean

Member

Manishearth commented Sep 24, 2016

@bors-servo try- r+ retry clean

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 24, 2016

Contributor

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #13361
Contributor

bors-servo commented Sep 24, 2016

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #13361
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 24, 2016

Contributor

📌 Commit ba743f5 has been approved by Manishearth

Contributor

bors-servo commented Sep 24, 2016

📌 Commit ba743f5 has been approved by Manishearth

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 24, 2016

Contributor

⌛️ Testing commit ba743f5 with merge 0dd005e...

Contributor

bors-servo commented Sep 24, 2016

⌛️ Testing commit ba743f5 with merge 0dd005e...

bors-servo added a commit that referenced this pull request Sep 24, 2016

Auto merge of #13404 - bholley:manage_node_data, r=Manishearth
 stylo: Manage servo node data directly from Servo

Servo-side changes for: https://bugzilla.mozilla.org/show_bug.cgi?id=1304913

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13404)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 24, 2016

Contributor

💔 Test failed - mac-rel-wpt

Contributor

bors-servo commented Sep 24, 2016

💔 Test failed - mac-rel-wpt

@Manishearth

This comment has been minimized.

Show comment
Hide comment
Member

Manishearth commented Sep 24, 2016

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 24, 2016

Contributor

⚡️ Previous build results for arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only mac-rel-wpt...

Contributor

bors-servo commented Sep 24, 2016

⚡️ Previous build results for arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only mac-rel-wpt...

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 24, 2016

Contributor

💔 Test failed - mac-rel-wpt

Contributor

bors-servo commented Sep 24, 2016

💔 Test failed - mac-rel-wpt

@Manishearth

This comment has been minimized.

Show comment
Hide comment
Member

Manishearth commented Sep 24, 2016

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 24, 2016

Contributor

⚡️ Previous build results for arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only mac-rel-wpt...

Contributor

bors-servo commented Sep 24, 2016

⚡️ Previous build results for arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only mac-rel-wpt...

@bors-servo

This comment has been minimized.

Show comment
Hide comment
Contributor

bors-servo commented Sep 24, 2016

@bors-servo bors-servo merged commit ba743f5 into servo:master Sep 24, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@bholley bholley deleted the bholley:manage_node_data branch Oct 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment