Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: Manage servo node data directly from Servo #13404

Merged
merged 2 commits into from Sep 24, 2016
Merged

stylo: Manage servo node data directly from Servo #13404

merged 2 commits into from Sep 24, 2016
+1,753 −1,346

Conversation

@bholley
Copy link
Contributor

bholley commented Sep 24, 2016 •
edited by larsbergstrom

Servo-side changes for: https://bugzilla.mozilla.org/show_bug.cgi?id=1304913

This change is Reviewable
@bholley
Regenerate bindings.
336ad0c
@highfive
Copy link

highfive commented Sep 24, 2016

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@bholley
Bug 1304913 - Have Servo manage node data directly without FFI calls.…
Loading status checks…
ba743f5 
… r=Manishearth

MozReview-Commit-ID: H8f8VP18TbM
@bholley bholley force-pushed the bholley:manage_node_data branch from 12f3a56 to ba743f5 Sep 24, 2016
@bholley
Copy link
Contributor Author

bholley commented Sep 24, 2016

@bors-servo try
bors-servo added a commit that referenced this pull request Sep 24, 2016
@bors-servo
Auto merge of #13404 - bholley:manage_node_data, r=<try>
Loading status checks…
e8e3dac 
 stylo: Manage servo node data directly from Servo

Servo-side changes for: https://bugzilla.mozilla.org/show_bug.cgi?id=1304913

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13404)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 24, 2016

⌛ Trying commit ba743f5 with merge e8e3dac...
@Manishearth
Copy link
Member

Manishearth commented Sep 24, 2016

(you can r=me when you need it -- carrying over review from bugzilla is fine)
@bholley
Copy link
Contributor Author

bholley commented Sep 24, 2016

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Sep 24, 2016

📌 Commit ba743f5 has been approved by Manishearth
@highfive highfive assigned Manishearth and unassigned metajack Sep 24, 2016
@Manishearth
Copy link
Member

Manishearth commented Sep 24, 2016

@bors-servo try- r+ retry clean
@bors-servo
Copy link
Contributor

bors-servo commented Sep 24, 2016

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #13361
@bors-servo
Copy link
Contributor

bors-servo commented Sep 24, 2016

📌 Commit ba743f5 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Sep 24, 2016

⌛ Testing commit ba743f5 with merge 0dd005e...
bors-servo added a commit that referenced this pull request Sep 24, 2016
@bors-servo
Auto merge of #13404 - bholley:manage_node_data, r=Manishearth
Loading status checks…
0dd005e 
 stylo: Manage servo node data directly from Servo

Servo-side changes for: https://bugzilla.mozilla.org/show_bug.cgi?id=1304913

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13404)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 24, 2016

💔 Test failed - mac-rel-wpt
@Manishearth
Copy link
Member

Manishearth commented Sep 24, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 24, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 24, 2016

💔 Test failed - mac-rel-wpt
@Manishearth
Copy link
Member

Manishearth commented Sep 24, 2016

@bors-servo retry
- #12654
@bors-servo
Copy link
Contributor

bors-servo commented Sep 24, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 24, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit ba743f5 into servo:master Sep 24, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Sep 24, 2016
Merged
@bholley bholley deleted the bholley:manage_node_data branch Oct 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@bholley @highfive @bors-servo @Manishearth @metajack
You can’t perform that action at this time.