Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace instances of old ServiceWorker specification URL with new one #13416
+115
−116
Conversation
The old specification URL is https://slightlyoff.github.io/ServiceWorker/spec/service_worker/ has been replaced by the new one at https://w3c.github.io/ServiceWorker/.
highfive
commented
Sep 25, 2016
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @larsbergstrom (or someone else) soon. |
highfive
commented
Sep 25, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Sep 25, 2016
|
|
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 25, 2016
Replace instances of old ServiceWorker specification URL with new one <!-- Please describe your changes on the following line: --> The old specification URL is https://slightlyoff.github.io/ServiceWorker/spec/service_worker/, which has been replaced by the new one at https://w3c.github.io/ServiceWorker/. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #13408 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because all the changes are in commented parts of the code. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> The old specification URL is https://slightlyoff.github.io/ServiceWorker/spec/service_worker/ has been replaced by the new one at https://w3c.github.io/ServiceWorker/. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13416) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vigneshsarma commentedSep 25, 2016
•
edited by larsbergstrom
The old specification URL is
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/, which has
been replaced by the new one at https://w3c.github.io/ServiceWorker/.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThe old specification URL is
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/ has
been replaced by the new one at https://w3c.github.io/ServiceWorker/.
This change is