Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make document url mutable and implement location.replace() #13418

Merged
merged 5 commits into from Nov 20, 2016
Merged

Make document url mutable and implement location.replace() #13418

merged 5 commits into from Nov 20, 2016
+117 −156

Commits on Nov 18, 2016

  1. Make 'Document.url' field mutable 

    Use DOMRefCell as the type of the url field.
    @stshine
    stshine committed Nov 18, 2016
    eca8f1d

  2. Move fragment navigation into Document object 

    Move the `check_and_scroll_fragment()` method into Document, make the
mothod set the fragment of url after navigation, and use the
`perform_a_scroll()` method to scroll rather than an individual
method. Also removes the broken `Window.fragment` fields.
    @stshine
    stshine committed Nov 18, 2016
    9863149

  3. Implement Location.replace

    @stshine
    stshine committed Nov 18, 2016
    fb6cc15

  4. Remove redundant url clones 

    They are now redundant since now document.url() returns a struct rather
than a reference.
    @stshine
    stshine committed Nov 18, 2016
    91f3d4f

Commits on Nov 19, 2016

  1. Minor fixes and update test expectations

    @stshine
    stshine committed Nov 19, 2016
    Loading status checks…
    5287e70
You can’t perform that action at this time.