New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make document url mutable and implement location.replace() #13418
Merged
+117
−156
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
eca8f1d
Make 'Document.url' field mutable
stshine 9863149
Move fragment navigation into Document object
stshine fb6cc15
Implement Location.replace
stshine 91f3d4f
Remove redundant url clones
stshine 5287e70
Minor fixes and update test expectations
stshine File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.
Implement Location.replace
- Loading branch information
commit fb6cc15208690acb4c66445b71f2ff8d1dcfcf73
| @@ -62,6 +62,18 @@ impl LocationMethods for Location { | ||
| fn Reload(&self) { | ||
| self.window.load_url(self.get_url(), true, true, None); | ||
| } | ||
|
|
||
| // https://html.spec.whatwg.org/multipage/#dom-location-replace | ||
| fn Replace(&self, url: USVString) -> ErrorResult { | ||
| // TODO: per spec, we should use the _API base URL_ specified by the | ||
| // _entry settings object_. | ||
| let base_url = self.window.get_url(); | ||
| if let Ok(url) = base_url.join(&url.0) { | ||
| self.window.load_url(url, true, false, None); | ||
| Ok(()) | ||
| } else { | ||
| Err(Error::Syntax) | ||
stshine
Author
Contributor
|
||
| } | ||
|
||
| } | ||
|
|
||
| // https://html.spec.whatwg.org/multipage/#dom-location-hash | ||
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I think this change will make us fail tests? The spec has text specifically about how Location.hash's setter is supposed to behave when passed an empty string, and it's supposed to have # appended to it afterwards.