Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the WebIDL parser #13431

Merged
merged 2 commits into from Sep 28, 2016
Merged

Update the WebIDL parser #13431

merged 2 commits into from Sep 28, 2016
+150 −531

Conversation

@nox
Copy link
Member

nox commented Sep 26, 2016 •
edited by larsbergstrom

This change is Reviewable
nox added 2 commits Sep 26, 2016
@nox
Properly keep track of our union typedef support in WebIDL.py
4c084ce
@nox
Update the WebIDL parser
Loading status checks…
107b92c
@highfive
Copy link

highfive commented Sep 26, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/bindings/codegen/parser/tests/test_method.py, components/script/dom/bindings/codegen/parser/tests/test_nullable_equivalency.py, components/script/dom/bindings/codegen/parser/tests/test_bytestring.py, components/script/dom/bindings/codegen/parser/tests/test_array.py, components/script/dom/bindings/codegen/parser/tests/test_attr.py, components/script/dom/bindings/codegen/parser/update.sh, components/script/dom/bindings/codegen/parser/union-typedef.patch, components/script/dom/bindings/codegen/parser/tests/test_union.py, components/script/dom/bindings/codegen/parser/bytestring.patch, components/script/dom/bindings/codegen/parser/tests/test_distinguishability.py, components/script/dom/bindings/codegen/parser/tests/test_array_of_interface.py, components/script/dom/bindings/codegen/parser/tests/test_arraybuffer.py, components/script/dom/bindings/codegen/parser/WebIDL.py
@highfive
Copy link

highfive commented Sep 26, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@Ms2ger
Copy link
Contributor

Ms2ger commented Sep 26, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 26, 2016

📌 Commit 107b92c has been approved by Ms2ger
@highfive highfive assigned Ms2ger and unassigned KiChjang Sep 26, 2016
@nox
Copy link
Member Author

nox commented Sep 27, 2016

@bors-servo retry
@KiChjang
Copy link
Member

KiChjang commented Sep 28, 2016

@bors-servo r=Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2016

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #13382
@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2016

📌 Commit 107b92c has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2016

⌛ Testing commit 107b92c with merge dd0a053...
bors-servo added a commit that referenced this pull request Sep 28, 2016
@bors-servo
Auto merge of #13431 - nox:webidl, r=Ms2ger
Loading status checks…
dd0a053 
Update the WebIDL parser

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13431)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2016

💔 Test failed - mac-rel-wpt
@KiChjang
Copy link
Member

KiChjang commented Sep 28, 2016

@bors-servo retry
@nox nox added S-awaiting-merge and removed S-tests-failed labels Sep 28, 2016
@nox
Copy link
Member Author

nox commented Sep 28, 2016

@bors-servo p=1
@nox
Copy link
Member Author

nox commented Sep 28, 2016

THIS MEANS WAR @Ms2ger

@bors-servo p=11

TAKE THAT
@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2016

⌛ Testing commit 107b92c with merge 341fb72...
bors-servo added a commit that referenced this pull request Sep 28, 2016
@bors-servo
Auto merge of #13431 - nox:webidl, r=Ms2ger
Loading status checks…
341fb72 
Update the WebIDL parser

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13431)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2016

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Sep 28, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2016

⚡ Previous build results for arm32, arm64, linux-dev, mac-dev-unit, windows-dev are reusable. Rebuilding only linux-rel, mac-rel-css, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit 107b92c into servo:master Sep 28, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nox @highfive @Ms2ger @bors-servo @KiChjang @jdm
You can’t perform that action at this time.