Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRebase of #12905: Fix #12193 Servo displays upper level Thai character in wrong place. #13442
Conversation
|
@bors-servo: try |
bors-servo
added a commit
that referenced
this pull request
Sep 26, 2016
|
|
highfive
commented
Sep 26, 2016
|
|
I suppose that this patch won't pass word breaking test until #12939 is fixed. |
|
Yes, but you could duplicate some of the relevant tests and make them use |
|
I will try to fix css-text-3_dev/html/word-break-break-all-007.htm like @jdm suggested. |
|
I just added new commit for fixing test. |
|
So I pull this #13506. |
|
More work happening in #13506. |
bors-servo
added a commit
that referenced
this pull request
Feb 1, 2017
A test case change is added to #13442: Fix #12193 Servo displays upper level Thai character in wrong place. <!-- Please describe your changes on the following line: --> <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13506) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedSep 26, 2016
•
edited by larsbergstrom
Taking over #12905
This change is